LinuxLists.cc - [PATCH] erofs: don't warn ztailpacking feature anymore

2023-02-27 08:55:25

Subject: [PATCH] erofs: don't warn ztailpacking feature anymore

From: Yue Hu <[email protected]>

The ztailpacking feature has been merged for a year, it has been mostly
stable now.

Signed-off-by: Yue Hu <[email protected]>
---
fs/erofs/super.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/erofs/super.c b/fs/erofs/super.c
index 19b1ae79cec4..733c22bcc3eb 100644
--- a/fs/erofs/super.c
+++ b/fs/erofs/super.c
@@ -417,8 +417,6 @@ static int erofs_read_superblock(struct super_block *sb)
/* handle multiple devices */
ret = erofs_scan_devices(sb, dsb);

- if (erofs_sb_has_ztailpacking(sbi))
- erofs_info(sb, "EXPERIMENTAL compressed inline data feature in use. Use at your own risk!");
if (erofs_is_fscache_mode(sb))
erofs_info(sb, "EXPERIMENTAL fscache-based on-demand read feature in use. Use at your own risk!");
if (erofs_sb_has_fragments(sbi))
--
2.17.1

2023-02-27 09:43:01

by Gao Xiang

[permalink] [raw]

Subject: Re: [PATCH] erofs: don't warn ztailpacking feature anymore

On 2023/2/27 16:44, Yue Hu wrote:
> From: Yue Hu <[email protected]>
>
> The ztailpacking feature has been merged for a year, it has been mostly
> stable now.
>
> Signed-off-by: Yue Hu <[email protected]>

Let's update erofs-utils as well?

> ---
> fs/erofs/super.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/erofs/super.c b/fs/erofs/super.c
> index 19b1ae79cec4..733c22bcc3eb 100644
> --- a/fs/erofs/super.c
> +++ b/fs/erofs/super.c
> @@ -417,8 +417,6 @@ static int erofs_read_superblock(struct super_block *sb)
> /* handle multiple devices */
> ret = erofs_scan_devices(sb, dsb);
>
> - if (erofs_sb_has_ztailpacking(sbi))
> - erofs_info(sb, "EXPERIMENTAL compressed inline data feature in use. Use at your own risk!");
> if (erofs_is_fscache_mode(sb))
> erofs_info(sb, "EXPERIMENTAL fscache-based on-demand read feature in use. Use at your own risk!");
> if (erofs_sb_has_fragments(sbi))

2023-02-27 09:46:47

by Yue Hu

[permalink] [raw]

Subject: Re: [PATCH] erofs: don't warn ztailpacking feature anymore

On Mon, 27 Feb 2023 17:42:40 +0800
Gao Xiang <[email protected]> wrote:

> On 2023/2/27 16:44, Yue Hu wrote:
> > From: Yue Hu <[email protected]>
> >
> > The ztailpacking feature has been merged for a year, it has been mostly
> > stable now.
> >
> > Signed-off-by: Yue Hu <[email protected]>
>
> Let's update erofs-utils as well?

Ok, I will update it later.

>
> > ---
> > fs/erofs/super.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/fs/erofs/super.c b/fs/erofs/super.c
> > index 19b1ae79cec4..733c22bcc3eb 100644
> > --- a/fs/erofs/super.c
> > +++ b/fs/erofs/super.c
> > @@ -417,8 +417,6 @@ static int erofs_read_superblock(struct super_block *sb)
> > /* handle multiple devices */
> > ret = erofs_scan_devices(sb, dsb);
> >
> > - if (erofs_sb_has_ztailpacking(sbi))
> > - erofs_info(sb, "EXPERIMENTAL compressed inline data feature in use. Use at your own risk!");
> > if (erofs_is_fscache_mode(sb))
> > erofs_info(sb, "EXPERIMENTAL fscache-based on-demand read feature in use. Use at your own risk!");
> > if (erofs_sb_has_fragments(sbi))

2023-03-03 00:53:31

by Gao Xiang

[permalink] [raw]

Subject: Re: [PATCH] erofs: don't warn ztailpacking feature anymore

On 2023/2/27 16:44, Yue Hu wrote:
> From: Yue Hu <[email protected]>
>
> The ztailpacking feature has been merged for a year, it has been mostly
> stable now.
>
> Signed-off-by: Yue Hu <[email protected]>

Reviewed-by: Gao Xiang <[email protected]>

Thanks,
Gao Xiang

> ---
> fs/erofs/super.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/erofs/super.c b/fs/erofs/super.c
> index 19b1ae79cec4..733c22bcc3eb 100644
> --- a/fs/erofs/super.c
> +++ b/fs/erofs/super.c
> @@ -417,8 +417,6 @@ static int erofs_read_superblock(struct super_block *sb)
> /* handle multiple devices */
> ret = erofs_scan_devices(sb, dsb);
>
> - if (erofs_sb_has_ztailpacking(sbi))
> - erofs_info(sb, "EXPERIMENTAL compressed inline data feature in use. Use at your own risk!");
> if (erofs_is_fscache_mode(sb))
> erofs_info(sb, "EXPERIMENTAL fscache-based on-demand read feature in use. Use at your own risk!");
> if (erofs_sb_has_fragments(sbi))

2023-04-16 14:31:17

by Chao Yu

[permalink] [raw]