2023-02-13 15:28:14

by Lucas Tanure

[permalink] [raw]
Subject: [PATCH 1/2] dt-bindings: mmc: rockchip-dw-mshc: Add RK3588 compatible string

Add RK3588 compatible string for SD interface.

Co-developed-by: Shawn Lin <[email protected]>
Signed-off-by: Shawn Lin <[email protected]>
Signed-off-by: Lucas Tanure <[email protected]>
---
Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml
index 67d7223f74da..211cd0b0bc5f 100644
--- a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml
+++ b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml
@@ -39,6 +39,7 @@ properties:
- rockchip,rk3368-dw-mshc
- rockchip,rk3399-dw-mshc
- rockchip,rk3568-dw-mshc
+ - rockchip,rk3588-dw-mshc
- rockchip,rv1108-dw-mshc
- rockchip,rv1126-dw-mshc
- const: rockchip,rk3288-dw-mshc
--
2.39.1



2023-02-13 15:28:16

by Lucas Tanure

[permalink] [raw]
Subject: [PATCH 2/2] arm64: dts: rockchip: rk3588: Add sdmmc node

Add SD Card node for RK3588s and RK3588.

Co-developed-by: Shawn Lin <[email protected]>
Signed-off-by: Shawn Lin <[email protected]>
Signed-off-by: Lucas Tanure <[email protected]>
---
arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 15 +++++++++++++++
1 file changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
index 005cde61b4b2..fca8503aed8c 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
@@ -1099,6 +1099,21 @@ gmac1_mtl_tx_setup: tx-queues-config {
};
};

+ sdmmc: mmc@fe2c0000 {
+ compatible = "rockchip,rk3588-dw-mshc", "rockchip,rk3288-dw-mshc";
+ reg = <0x0 0xfe2c0000 0x0 0x4000>;
+ interrupts = <GIC_SPI 203 IRQ_TYPE_LEVEL_HIGH 0>;
+ clocks = <&scmi_clk SCMI_HCLK_SD>, <&scmi_clk SCMI_CCLK_SD>,
+ <&cru SCLK_SDMMC_DRV>, <&cru SCLK_SDMMC_SAMPLE>;
+ clock-names = "biu", "ciu", "ciu-drive", "ciu-sample";
+ fifo-depth = <0x100>;
+ max-frequency = <200000000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_det &sdmmc_bus4>;
+ power-domains = <&power RK3588_PD_SDMMC>;
+ status = "disabled";
+ };
+
sdhci: mmc@fe2e0000 {
compatible = "rockchip,rk3588-dwcmshc";
reg = <0x0 0xfe2e0000 0x0 0x10000>;
--
2.39.1


2023-02-13 15:43:20

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: mmc: rockchip-dw-mshc: Add RK3588 compatible string

On 13/02/2023 16:27, Lucas Tanure wrote:
> Add RK3588 compatible string for SD interface.
>
> Co-developed-by: Shawn Lin <[email protected]>
> Signed-off-by: Shawn Lin <[email protected]>
> Signed-off-by: Lucas Tanure <[email protected]>
> ---
> Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml | 1 +


Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof


2023-02-13 16:37:22

by Heiko Stuebner

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: mmc: rockchip-dw-mshc: Add RK3588 compatible string

Am Montag, 13. Februar 2023, 16:27:39 CET schrieb Lucas Tanure:
> Add RK3588 compatible string for SD interface.
>
> Co-developed-by: Shawn Lin <[email protected]>
> Signed-off-by: Shawn Lin <[email protected]>
> Signed-off-by: Lucas Tanure <[email protected]>

Reviewed-by: Heiko Stuebner <[email protected]>



2023-02-14 12:19:44

by Ulf Hansson

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: mmc: rockchip-dw-mshc: Add RK3588 compatible string

On Mon, 13 Feb 2023 at 16:27, Lucas Tanure <[email protected]> wrote:
>
> Add RK3588 compatible string for SD interface.
>
> Co-developed-by: Shawn Lin <[email protected]>
> Signed-off-by: Shawn Lin <[email protected]>
> Signed-off-by: Lucas Tanure <[email protected]>

Applied for next, thanks!

Kind regards
Uffe


> ---
> Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml
> index 67d7223f74da..211cd0b0bc5f 100644
> --- a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml
> @@ -39,6 +39,7 @@ properties:
> - rockchip,rk3368-dw-mshc
> - rockchip,rk3399-dw-mshc
> - rockchip,rk3568-dw-mshc
> + - rockchip,rk3588-dw-mshc
> - rockchip,rv1108-dw-mshc
> - rockchip,rv1126-dw-mshc
> - const: rockchip,rk3288-dw-mshc
> --
> 2.39.1
>

2023-02-28 10:36:22

by Lucas Tanure

[permalink] [raw]
Subject: [PATCH v2] arm64: dts: rockchip: rk3588: Add sdmmc node

Add SD Card node for RK3588s and RK3588.

Co-developed-by: Shawn Lin <[email protected]>
Signed-off-by: Shawn Lin <[email protected]>
Signed-off-by: Lucas Tanure <[email protected]>
---
Changes Since v1:
None. Re-submitting this patch alone as the first patch of this series was
already accepted.
---
arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 15 +++++++++++++++
1 file changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
index 005cde61b4b2..fca8503aed8c 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
@@ -1099,6 +1099,21 @@ gmac1_mtl_tx_setup: tx-queues-config {
};
};

+ sdmmc: mmc@fe2c0000 {
+ compatible = "rockchip,rk3588-dw-mshc", "rockchip,rk3288-dw-mshc";
+ reg = <0x0 0xfe2c0000 0x0 0x4000>;
+ interrupts = <GIC_SPI 203 IRQ_TYPE_LEVEL_HIGH 0>;
+ clocks = <&scmi_clk SCMI_HCLK_SD>, <&scmi_clk SCMI_CCLK_SD>,
+ <&cru SCLK_SDMMC_DRV>, <&cru SCLK_SDMMC_SAMPLE>;
+ clock-names = "biu", "ciu", "ciu-drive", "ciu-sample";
+ fifo-depth = <0x100>;
+ max-frequency = <200000000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_det &sdmmc_bus4>;
+ power-domains = <&power RK3588_PD_SDMMC>;
+ status = "disabled";
+ };
+
sdhci: mmc@fe2e0000 {
compatible = "rockchip,rk3588-dwcmshc";
reg = <0x0 0xfe2e0000 0x0 0x10000>;
--
2.39.2


2023-03-07 23:37:57

by Heiko Stuebner

[permalink] [raw]
Subject: Re: [PATCH v2] arm64: dts: rockchip: rk3588: Add sdmmc node

On Tue, 28 Feb 2023 10:36:10 +0000, Lucas Tanure wrote:
> Add SD Card node for RK3588s and RK3588.
>
>

Applied, thanks!

[1/1] arm64: dts: rockchip: rk3588: Add sdmmc node
commit: dbe406d1397ffccd4a0f85daef456291f265505a

Best regards,
--
Heiko Stuebner <[email protected]>