2023-02-28 13:02:48

by Nick Alcock

Subject: [PATCH 02/20] pinctrl: amd: remove MODULE_LICENSE in non-modules

Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So remove it in the files in this commit, none of which can be built as
modules.

Signed-off-by: Nick Alcock <[email protected]>
Suggested-by: Luis Chamberlain <[email protected]>
Cc: Luis Chamberlain <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: Hitomi Hasegawa <[email protected]>
Cc: Basavaraj Natikar <[email protected]>
Cc: Shyam Sundar S K <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: [email protected]
---
drivers/pinctrl/pinctrl-amd.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c
index 9bc6e3922e78e..f9928469c1d04 100644
--- a/drivers/pinctrl/pinctrl-amd.c
+++ b/drivers/pinctrl/pinctrl-amd.c
@@ -1205,6 +1205,5 @@ static struct platform_driver amd_gpio_driver = {

module_platform_driver(amd_gpio_driver);

-MODULE_LICENSE("GPL v2");
MODULE_AUTHOR("Ken Xue <[email protected]>, Jeff Wu <[email protected]>");
MODULE_DESCRIPTION("AMD GPIO pinctrl driver");
--
2.39.1.268.g9de2f9a303

2023-03-07 13:11:40

by Linus Walleij

Subject: Re: [PATCH 02/20] pinctrl: amd: remove MODULE_LICENSE in non-modules

On Tue, Feb 28, 2023 at 2:02 PM Nick Alcock <[email protected]> wrote:

> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <[email protected]>
> Suggested-by: Luis Chamberlain <[email protected]>
> Cc: Luis Chamberlain <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: Hitomi Hasegawa <[email protected]>
> Cc: Basavaraj Natikar <[email protected]>
> Cc: Shyam Sundar S K <[email protected]>
> Cc: Linus Walleij <[email protected]>
> Cc: [email protected]

Can I just merge the 3 pinctrl patches to the pinctrl tree or are there
any dependencies?

Yours,
Linus Walleij