2023-02-28 15:17:16

by Guenter Roeck

Subject: [PATCH] watchdog: imx2_wdg: Declare local symbols static

0-day complains:

drivers/watchdog/imx2_wdt.c:442:22: sparse:
symbol 'imx_wdt' was not declared. Should it be static?
drivers/watchdog/imx2_wdt.c:446:22: sparse:
symbol 'imx_wdt_legacy' was not declared. Should it be static?

Declare as static variables.

Fixes: e42c73f1ef0d ("watchdog: imx2_wdg: suspend watchdog in WAIT mode")
Cc: Andrej Picej <[email protected]>
Signed-off-by: Guenter Roeck <[email protected]>
---
drivers/watchdog/imx2_wdt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c
index 19ab7b3d286b..6fcc3596103c 100644
--- a/drivers/watchdog/imx2_wdt.c
+++ b/drivers/watchdog/imx2_wdt.c
@@ -439,11 +439,11 @@ static int __maybe_unused imx2_wdt_resume(struct device *dev)
static SIMPLE_DEV_PM_OPS(imx2_wdt_pm_ops, imx2_wdt_suspend,
imx2_wdt_resume);

-struct imx2_wdt_data imx_wdt = {
+static struct imx2_wdt_data imx_wdt = {
.wdw_supported = true,
};

-struct imx2_wdt_data imx_wdt_legacy = {
+static struct imx2_wdt_data imx_wdt_legacy = {
.wdw_supported = false,
};

--
2.39.1

2023-03-02 10:02:22

by Andrej Picej

Subject: Re: [PATCH] watchdog: imx2_wdg: Declare local symbols static

On 28. 02. 23 16:16, Guenter Roeck wrote:
> 0-day complains:
>
> drivers/watchdog/imx2_wdt.c:442:22: sparse:
> symbol 'imx_wdt' was not declared. Should it be static?
> drivers/watchdog/imx2_wdt.c:446:22: sparse:
> symbol 'imx_wdt_legacy' was not declared. Should it be static?
>
> Declare as static variables.
>
> Fixes: e42c73f1ef0d ("watchdog: imx2_wdg: suspend watchdog in WAIT mode")
> Cc: Andrej Picej <[email protected]>
> Signed-off-by: Guenter Roeck <[email protected]>

Hi Guenter,

thanks for the fix. Sorry for the trouble.

Best regards,
Andrej