2023-03-02 21:56:05

by Nick Alcock

[permalink] [raw]
Subject: [PATCH 16/17] zpool: remove MODULE_LICENSE in non-modules

Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So remove it in the files in this commit, none of which can be built as
modules.

Signed-off-by: Nick Alcock <[email protected]>
Suggested-by: Luis Chamberlain <[email protected]>
Cc: Luis Chamberlain <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: Hitomi Hasegawa <[email protected]>
Cc: Dan Streetman <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: [email protected]
---
mm/zpool.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/mm/zpool.c b/mm/zpool.c
index 571f5c5031dda..6a19c4a58f77b 100644
--- a/mm/zpool.c
+++ b/mm/zpool.c
@@ -395,6 +395,5 @@ bool zpool_can_sleep_mapped(struct zpool *zpool)
return zpool->driver->sleep_mapped;
}

-MODULE_LICENSE("GPL");
MODULE_AUTHOR("Dan Streetman <[email protected]>");
MODULE_DESCRIPTION("Common API for compressed memory storage");
--
2.39.1.268.g9de2f9a303