2023-03-02 22:20:43

by Nick Alcock

[permalink] [raw]
Subject: [PATCH 08/17] lib: remove MODULE_LICENSE in non-modules

Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So remove it in the files in this commit, none of which can be built as
modules.

Signed-off-by: Nick Alcock <[email protected]>
Suggested-by: Luis Chamberlain <[email protected]>
Cc: Luis Chamberlain <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: Hitomi Hasegawa <[email protected]>
---
lib/glob.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/lib/glob.c b/lib/glob.c
index 15b73f490720c..5c30606a1b92e 100644
--- a/lib/glob.c
+++ b/lib/glob.c
@@ -7,7 +7,6 @@
* both usually compiled in and the module overhead goes away.
*/
MODULE_DESCRIPTION("glob(7) matching");
-MODULE_LICENSE("Dual MIT/GPL");

/**
* glob_match - Shell-style pattern matching, like !fnmatch(pat, str, 0)
--
2.39.1.268.g9de2f9a303