2023-03-05 12:24:38

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH] dt-bindings: soc: qcom: smd-rpm: re-add missing qcom,rpm-msm8994

Re-add the qcom,rpm-msm8994 compatible, dropped during conversion from
TXT to DT schema:

apq8094-sony-xperia-kitakami-karin_windy.dtb: smd: rpm:rpm-requests:compatible:0: 'qcom,rpm-msm8994' is not one of ['qcom,rpm-apq8084' ...]

Fixes: f935a752f229 ("dt-bindings: soc: qcom: smd-rpm: Convert binding to YAML schema")
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml
index 16fd67c0bd1f..3580b209cd4a 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml
@@ -40,6 +40,7 @@ properties:
- qcom,rpm-msm8953
- qcom,rpm-msm8974
- qcom,rpm-msm8976
+ - qcom,rpm-msm8994
- qcom,rpm-msm8996
- qcom,rpm-msm8998
- qcom,rpm-sdm660
@@ -84,6 +85,7 @@ if:
- qcom,rpm-msm8974
- qcom,rpm-msm8976
- qcom,rpm-msm8953
+ - qcom,rpm-msm8994
then:
properties:
qcom,glink-channels: false
--
2.34.1



2023-03-06 10:46:29

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: soc: qcom: smd-rpm: re-add missing qcom,rpm-msm8994



On 5.03.2023 13:24, Krzysztof Kozlowski wrote:
> Re-add the qcom,rpm-msm8994 compatible, dropped during conversion from
> TXT to DT schema:
>
> apq8094-sony-xperia-kitakami-karin_windy.dtb: smd: rpm:rpm-requests:compatible:0: 'qcom,rpm-msm8994' is not one of ['qcom,rpm-apq8084' ...]
>
> Fixes: f935a752f229 ("dt-bindings: soc: qcom: smd-rpm: Convert binding to YAML schema")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
It's funny how it was used in the dt in like 2016 but only added
to the driver in 2020..

Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml
> index 16fd67c0bd1f..3580b209cd4a 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml
> @@ -40,6 +40,7 @@ properties:
> - qcom,rpm-msm8953
> - qcom,rpm-msm8974
> - qcom,rpm-msm8976
> + - qcom,rpm-msm8994
> - qcom,rpm-msm8996
> - qcom,rpm-msm8998
> - qcom,rpm-sdm660
> @@ -84,6 +85,7 @@ if:
> - qcom,rpm-msm8974
> - qcom,rpm-msm8976
> - qcom,rpm-msm8953
> + - qcom,rpm-msm8994
> then:
> properties:
> qcom,glink-channels: false

2023-03-07 19:57:19

by Petr Vorel

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: soc: qcom: smd-rpm: re-add missing qcom,rpm-msm8994

Hi all,

Reviewed-by: Petr Vorel <[email protected]>

Kind regards,
Petr

2023-03-08 08:40:24

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: soc: qcom: smd-rpm: re-add missing qcom,rpm-msm8994

On 07/03/2023 20:48, Petr Vorel wrote:
> Hi all,
>
> Reviewed-by: Petr Vorel <[email protected]>

What did you review?

Best regards,
Krzysztof


2023-03-08 22:19:41

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: soc: qcom: smd-rpm: re-add missing qcom,rpm-msm8994


On Sun, 05 Mar 2023 13:24:28 +0100, Krzysztof Kozlowski wrote:
> Re-add the qcom,rpm-msm8994 compatible, dropped during conversion from
> TXT to DT schema:
>
> apq8094-sony-xperia-kitakami-karin_windy.dtb: smd: rpm:rpm-requests:compatible:0: 'qcom,rpm-msm8994' is not one of ['qcom,rpm-apq8084' ...]
>
> Fixes: f935a752f229 ("dt-bindings: soc: qcom: smd-rpm: Convert binding to YAML schema")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>

Acked-by: Rob Herring <[email protected]>


2023-03-22 14:58:50

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: soc: qcom: smd-rpm: re-add missing qcom,rpm-msm8994

On Sun, 5 Mar 2023 13:24:28 +0100, Krzysztof Kozlowski wrote:
> Re-add the qcom,rpm-msm8994 compatible, dropped during conversion from
> TXT to DT schema:
>
> apq8094-sony-xperia-kitakami-karin_windy.dtb: smd: rpm:rpm-requests:compatible:0: 'qcom,rpm-msm8994' is not one of ['qcom,rpm-apq8084' ...]
>
>

Applied, thanks!

[1/1] dt-bindings: soc: qcom: smd-rpm: re-add missing qcom,rpm-msm8994
commit: 34d84c3b0f63978efcb5136a6fd2e7e9d889da70

Best regards,
--
Bjorn Andersson <[email protected]>