2023-03-06 04:01:11

by Randy Dunlap

Subject: [PATCH 4/7 v4] sh: math-emu: fix macro redefined warning

Fix a warning that was reported by the kernel test robot:

In file included from ../include/math-emu/soft-fp.h:27,
from ../arch/sh/math-emu/math.c:22:
../arch/sh/include/asm/sfp-machine.h:17: warning: "__BYTE_ORDER" redefined
17 | #define __BYTE_ORDER __BIG_ENDIAN
In file included from ../arch/sh/math-emu/math.c:21:
../arch/sh/math-emu/sfp-util.h:71: note: this is the location of the previous definition
71 | #define __BYTE_ORDER __LITTLE_ENDIAN

Fixes: b929926f01f2 ("sh: define __BIG_ENDIAN for math-emu")
Signed-off-by: Randy Dunlap <[email protected]>
Reported-by: kernel test robot <[email protected]>
Link: lore.kernel.org/r/[email protected]
Cc: John Paul Adrian Glaubitz <[email protected]>
Cc: Yoshinori Sato <[email protected]>
Cc: Rich Felker <[email protected]>
Cc: [email protected]
Reviewed-by: Geert Uytterhoeven <[email protected]>
Cc: [email protected]
---
v2: add Reviewed-by Geert,
rebase to linux-next-20211115
v3: skipped
v4: refresh & resend

arch/sh/math-emu/sfp-util.h | 4 ----
1 file changed, 4 deletions(-)

diff -- a/arch/sh/math-emu/sfp-util.h b/arch/sh/math-emu/sfp-util.h
--- a/arch/sh/math-emu/sfp-util.h
+++ b/arch/sh/math-emu/sfp-util.h
@@ -67,7 +67,3 @@
} while (0)

#define abort() return 0
-
-#define __BYTE_ORDER __LITTLE_ENDIAN
-
-

2023-03-19 19:49:21

by John Paul Adrian Glaubitz

Subject: Re: [PATCH 4/7 v4] sh: math-emu: fix macro redefined warning

On Sun, 2023-03-05 at 20:00 -0800, Randy Dunlap wrote:
> Fix a warning that was reported by the kernel test robot:
>
> In file included from ../include/math-emu/soft-fp.h:27,
> from ../arch/sh/math-emu/math.c:22:
> ../arch/sh/include/asm/sfp-machine.h:17: warning: "__BYTE_ORDER" redefined
> 17 | #define __BYTE_ORDER __BIG_ENDIAN
> In file included from ../arch/sh/math-emu/math.c:21:
> ../arch/sh/math-emu/sfp-util.h:71: note: this is the location of the previous definition
> 71 | #define __BYTE_ORDER __LITTLE_ENDIAN
>
> Fixes: b929926f01f2 ("sh: define __BIG_ENDIAN for math-emu")
> Signed-off-by: Randy Dunlap <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Link: lore.kernel.org/r/[email protected]
> Cc: John Paul Adrian Glaubitz <[email protected]>
> Cc: Yoshinori Sato <[email protected]>
> Cc: Rich Felker <[email protected]>
> Cc: [email protected]
> Reviewed-by: Geert Uytterhoeven <[email protected]>
> Cc: [email protected]
> ---
> v2: add Reviewed-by Geert,
> rebase to linux-next-20211115
> v3: skipped
> v4: refresh & resend
>
> arch/sh/math-emu/sfp-util.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff -- a/arch/sh/math-emu/sfp-util.h b/arch/sh/math-emu/sfp-util.h
> --- a/arch/sh/math-emu/sfp-util.h
> +++ b/arch/sh/math-emu/sfp-util.h
> @@ -67,7 +67,3 @@
> } while (0)
>
> #define abort() return 0
> -
> -#define __BYTE_ORDER __LITTLE_ENDIAN
> -
> -

Reviewed-by: John Paul Adrian Glaubitz <[email protected]>

--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913