2023-03-06 09:36:16

by Charles Keepax

[permalink] [raw]
Subject: Re: [PATCH v2 5/5] ASoC: cs35l45: Hibernation support

On Fri, Mar 03, 2023 at 01:21:51PM -0600, Vlad Karpovich wrote:
> From: "Vlad.Karpovich" <[email protected]>
>
> Adds support for a low-power Hibernation State.
> In this state, all register contents are lost, but the contents of
> RAM are retained. In the Hibernation State, only always-on digital
> functions to support wake-up are enabled.

Yeah perhaps clarify that this relates to the DSP, something like
"Add support for a low-power hibernation state for the DSP. In
this state the DSP RAM contents are maintained, such that
firmware does not need to be re-downloaded, but the rest of the
chip's register state is lost."

But rest of it looks good to me:

Acked-by: Charles Keepax <[email protected]>

Thanks,
Charles