2023-03-07 02:47:01

by William Qiu

[permalink] [raw]
Subject: [PATCH v5 0/2] StarFive's SDIO/eMMC driver support

Hi,

This patchset adds initial rudimentary support for the StarFive
designware mobile storage host controller driver. And this driver will
be used in StarFive's VisionFive 2 board. The main purpose of adding
this driver is to accommodate the ultra-high speed mode of eMMC.

Changes v4->v5:
- Added a incremental updates to fix a bug that prev_err is uninitialized.
- Dropped the merged patches.
- Dropped the dts patch.
- Sorted compatible alphabetically in yaml.

Changes v3->v4:
- Added documentation to describe StarFive System Controller Registers.
- Added aon_syscon and stg_syscon node.
- Fixed some checkpatch errors/warnings.

Changes v2->v3:
- Wraped commit message according to Linux coding style.
- Rephrased the description of the patches.
- Changed the description of syscon regsiter.
- Dropped redundant properties.

Changes v1->v2:
- Renamed the dt-binding 'starfive,jh7110-sdio.yaml' to 'starfive,jh7110-mmc.yaml'.
- Changed the type of 'starfive,syscon' and modify its description.
- Deleted unused head files like '#include <linux/gpio.h>'.
- Added comment for the 'rise_point' and 'fall_point'.
- Changed the API 'num_caps' to 'common_caps'.
- Changed the node name 'sys_syscon' to 'syscon'.
- Changed the node name 'sdio' to 'mmc'.

The patch series is based on v6.1.

William Qiu (2):
dt-bindings: syscon: Add StarFive syscon doc
mmc: starfive: Add initialization of prev_err

.../bindings/soc/starfive/jh7110-syscon.yaml | 41 +++++++++++++++++++
MAINTAINERS | 5 +++
drivers/mmc/host/dw_mmc-starfive.c | 2 +-
3 files changed, 47 insertions(+), 1 deletion(-)
create mode 100644 Documentation/devicetree/bindings/soc/starfive/jh7110-syscon.yaml

--
2.34.1



2023-03-07 02:47:03

by William Qiu

[permalink] [raw]
Subject: [PATCH v5 1/2] dt-bindings: syscon: Add StarFive syscon doc

Add documentation to describe StarFive System Controller Registers.

Signed-off-by: William Qiu <[email protected]>
Reviewed-by: Conor Dooley <[email protected]>
---
.../bindings/soc/starfive/jh7110-syscon.yaml | 41 +++++++++++++++++++
MAINTAINERS | 5 +++
2 files changed, 46 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/starfive/jh7110-syscon.yaml

diff --git a/Documentation/devicetree/bindings/soc/starfive/jh7110-syscon.yaml b/Documentation/devicetree/bindings/soc/starfive/jh7110-syscon.yaml
new file mode 100644
index 000000000000..72c8850602b5
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/starfive/jh7110-syscon.yaml
@@ -0,0 +1,41 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/starfive/jh7110-syscon.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: StarFive JH7110 SoC system controller
+
+maintainers:
+ - William Qiu <[email protected]>
+
+description: |
+ The StarFive JH7110 SoC system controller provides register information such
+ as offset, mask and shift to configure related modules such as MMC and PCIe.
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - starfive,jh7110-aon-syscon
+ - starfive,jh7110-stg-syscon
+ - starfive,jh7110-sys-syscon
+ - const: syscon
+
+ reg:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ syscon@10240000 {
+ compatible = "starfive,jh7110-stg-syscon", "syscon";
+ reg = <0x10240000 0x1000>;
+ };
+
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 644ac9479a6e..fc9d1781516a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19665,6 +19665,11 @@ F: Documentation/devicetree/bindings/reset/starfive,jh7100-reset.yaml
F: drivers/reset/starfive/reset-starfive-jh71*
F: include/dt-bindings/reset/starfive?jh71*.h

+STARFIVE JH7110 SYSCON
+M: William Qiu <[email protected]>
+S: Supported
+F: Documentation/devicetree/bindings/soc/starfive/jh7110-syscon.yaml
+
STATIC BRANCH/CALL
M: Peter Zijlstra <[email protected]>
M: Josh Poimboeuf <[email protected]>
--
2.34.1


2023-03-07 09:00:54

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v5 1/2] dt-bindings: syscon: Add StarFive syscon doc

On 07/03/2023 03:46, William Qiu wrote:
> Add documentation to describe StarFive System Controller Registers.

Use subject prefixes matching the subsystem (which you can get for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching). This is not "syscon" subsystem, but rather
starfive.

>
> Signed-off-by: William Qiu <[email protected]>
> Reviewed-by: Conor Dooley <[email protected]>
> ---
> .../bindings/soc/starfive/jh7110-syscon.yaml | 41 +++++++++++++++++++
> MAINTAINERS | 5 +++
> 2 files changed, 46 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/starfive/jh7110-syscon.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/starfive/jh7110-syscon.yaml b/Documentation/devicetree/bindings/soc/starfive/jh7110-syscon.yaml
> new file mode 100644
> index 000000000000..72c8850602b5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/starfive/jh7110-syscon.yaml

Filename: starfive,jh7110-syscon.yaml



Best regards,
Krzysztof


2023-03-08 05:59:50

by William Qiu

[permalink] [raw]
Subject: Re: [PATCH v5 1/2] dt-bindings: syscon: Add StarFive syscon doc



On 2023/3/7 17:00, Krzysztof Kozlowski wrote:
> On 07/03/2023 03:46, William Qiu wrote:
>> Add documentation to describe StarFive System Controller Registers.
>
> Use subject prefixes matching the subsystem (which you can get for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching). This is not "syscon" subsystem, but rather
> starfive.
>
Will update.
>>
>> Signed-off-by: William Qiu <[email protected]>
>> Reviewed-by: Conor Dooley <[email protected]>
>> ---
>> .../bindings/soc/starfive/jh7110-syscon.yaml | 41 +++++++++++++++++++
>> MAINTAINERS | 5 +++
>> 2 files changed, 46 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/soc/starfive/jh7110-syscon.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/soc/starfive/jh7110-syscon.yaml b/Documentation/devicetree/bindings/soc/starfive/jh7110-syscon.yaml
>> new file mode 100644
>> index 000000000000..72c8850602b5
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/soc/starfive/jh7110-syscon.yaml
>
> Filename: starfive,jh7110-syscon.yaml
>

Will update.
Thanks for taking times to review this patch series.

Best regards
William
>
>
> Best regards,
> Krzysztof
>