2023-03-07 13:30:23

by Konrad Dybcio

Subject: [PATCH v2] clk: Print an info line before disabling unused clocks

Currently, the regulator framework informs us before calling into
their unused cleanup paths, which eases at least some debugging. The
same could be beneficial for clocks, so that random shutdowns shortly
after most initcalls are done can be less of a guess.

Add a pr_info before disabling unused clocks to do so.

Reviewed-by: Marijn Suijten <[email protected]>
Signed-off-by: Konrad Dybcio <[email protected]>
---
v1 -> v2:
- Don't add 'else' right before a return
- Add Marijn's r-b

drivers/clk/clk.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index ae07685c7588..115a80fda3f9 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -1406,6 +1406,8 @@ static int __init clk_disable_unused(void)
return 0;
}

+ pr_info("clk: Disabling unused clocks\n");
+
clk_prepare_lock();

hlist_for_each_entry(core, &clk_root_list, child_node)
--
2.39.2

2023-03-29 19:00:58

by Stephen Boyd

Subject: Re: [PATCH v2] clk: Print an info line before disabling unused clocks

Quoting Konrad Dybcio (2023-03-07 05:29:28)
> Currently, the regulator framework informs us before calling into
> their unused cleanup paths, which eases at least some debugging. The
> same could be beneficial for clocks, so that random shutdowns shortly
> after most initcalls are done can be less of a guess.
>
> Add a pr_info before disabling unused clocks to do so.
>
> Reviewed-by: Marijn Suijten <[email protected]>
> Signed-off-by: Konrad Dybcio <[email protected]>
> ---

Applied to clk-next