2023-02-10 01:20:53

by Yang Yang

[permalink] [raw]
Subject: [PATCH v6 5/6] ksm: add zero_pages_sharing documentation

From: xu xin <[email protected]>

When enabling use_zero_pages, pages_sharing cannot represent how
much memory saved indeed. zero_pages_sharing + pages_sharing does.
add the description of zero_pages_sharing.

Cc: Xiaokai Ran <[email protected]>
Cc: Yang Yang <[email protected]>
Cc: Jiang Xuexin <[email protected]>
Cc: Claudio Imbrenda <[email protected]>
Cc: David Hildenbrand <[email protected]>
Signed-off-by: xu xin <[email protected]>
---
Documentation/admin-guide/mm/ksm.rst | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/Documentation/admin-guide/mm/ksm.rst b/Documentation/admin-guide/mm/ksm.rst
index fb6ba2002a4b..f160f9487a90 100644
--- a/Documentation/admin-guide/mm/ksm.rst
+++ b/Documentation/admin-guide/mm/ksm.rst
@@ -173,6 +173,13 @@ stable_node_chains
the number of KSM pages that hit the ``max_page_sharing`` limit
stable_node_dups
number of duplicated KSM pages
+zero_pages_sharing
+ how many empty pages are sharing kernel zero page(s) instead of
+ with each other as it would happen normally. Only effective when
+ enabling ``use_zero_pages`` knob.
+
+When enabling ``use_zero_pages``, the sum of ``pages_sharing`` +
+``zero_pages_sharing`` represents how much really saved by KSM.

A high ratio of ``pages_sharing`` to ``pages_shared`` indicates good
sharing, but a high ratio of ``pages_unshared`` to ``pages_sharing``
--
2.15.2


2023-03-07 19:11:25

by Claudio Imbrenda

[permalink] [raw]
Subject: Re: [PATCH v6 5/6] ksm: add zero_pages_sharing documentation

On Fri, 10 Feb 2023 09:20:42 +0800 (CST)
<[email protected]> wrote:

> From: xu xin <[email protected]>
>
> When enabling use_zero_pages, pages_sharing cannot represent how
> much memory saved indeed. zero_pages_sharing + pages_sharing does.
> add the description of zero_pages_sharing.
>
> Cc: Xiaokai Ran <[email protected]>
> Cc: Yang Yang <[email protected]>
> Cc: Jiang Xuexin <[email protected]>
> Cc: Claudio Imbrenda <[email protected]>
> Cc: David Hildenbrand <[email protected]>
> Signed-off-by: xu xin <[email protected]>
> ---
> Documentation/admin-guide/mm/ksm.rst | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/admin-guide/mm/ksm.rst b/Documentation/admin-guide/mm/ksm.rst
> index fb6ba2002a4b..f160f9487a90 100644
> --- a/Documentation/admin-guide/mm/ksm.rst
> +++ b/Documentation/admin-guide/mm/ksm.rst
> @@ -173,6 +173,13 @@ stable_node_chains
> the number of KSM pages that hit the ``max_page_sharing`` limit
> stable_node_dups
> number of duplicated KSM pages
> +zero_pages_sharing
> + how many empty pages are sharing kernel zero page(s) instead of

how many empty pages are sharing the kernel zero page(s) instead of
other user pages as it would happen normally. Only meaningful when
``use_zero_pages`` is enabled.

> + with each other as it would happen normally. Only effective when
> + enabling ``use_zero_pages`` knob.
> +
> +When enabling ``use_zero_pages``, the sum of ``pages_sharing`` +

When ``use_zero_pages`` is enabled, the sum of ``pages_sharing`` +

> +``zero_pages_sharing`` represents how much really saved by KSM.

``zero_pages_sharing`` represents the actual number of pages saved
by KSM.

>
> A high ratio of ``pages_sharing`` to ``pages_shared`` indicates good
> sharing, but a high ratio of ``pages_unshared`` to ``pages_sharing``