2023-03-07 22:47:15

by Ondrej Zary

Subject: [PATCH 03/32] pata_parport-bpck6: don't cast pi->pardev to struct pardevice *

pi->pardev is struct pardevice *, no need to cast it to the same type.
Also clean up the return mess.

Signed-off-by: Ondrej Zary <[email protected]>
---
drivers/ata/pata_parport/bpck6.c | 24 ++++++------------------
1 file changed, 6 insertions(+), 18 deletions(-)

diff --git a/drivers/ata/pata_parport/bpck6.c b/drivers/ata/pata_parport/bpck6.c
index 4d6edb9c1245..fa1f7d4fe3cb 100644
--- a/drivers/ata/pata_parport/bpck6.c
+++ b/drivers/ata/pata_parport/bpck6.c
@@ -74,30 +74,18 @@ static void bpck6_disconnect(struct pi_adapter *pi)
static int bpck6_test_port(struct pi_adapter *pi) /* check for 8-bit port */
{
dev_dbg(&pi->dev, "PARPORT indicates modes=%x for lp=0x%lx\n",
- ((struct pardevice *)(pi->pardev))->port->modes,
- ((struct pardevice *)(pi->pardev))->port->base);
+ pi->pardev->port->modes, pi->pardev->port->base);

/*copy over duplicate stuff.. initialize state info*/
PPCSTRUCT(pi)->ppc_id=pi->unit;
PPCSTRUCT(pi)->lpt_addr=pi->port;

- /* look at the parport device to see if what modes we can use */
- if(((struct pardevice *)(pi->pardev))->port->modes &
- (PARPORT_MODE_EPP)
- )
- {
- return 5; /* Can do EPP*/
- }
- else if(((struct pardevice *)(pi->pardev))->port->modes &
- (PARPORT_MODE_TRISTATE)
- )
- {
+ /* look at the parport device to see what modes we can use */
+ if (pi->pardev->port->modes & PARPORT_MODE_EPP)
+ return 5; /* Can do EPP */
+ if (pi->pardev->port->modes & PARPORT_MODE_TRISTATE)
return 2;
- }
- else /*Just flat SPP*/
- {
- return 1;
- }
+ return 1; /* Just flat SPP */
}

static int bpck6_probe_unit(struct pi_adapter *pi)
--
Ondrej Zary

2023-03-08 18:15:56

by Sergey Shtylyov

Subject: Re: [PATCH 03/32] pata_parport-bpck6: don't cast pi->pardev to struct pardevice *

On 3/8/23 1:45 AM, Ondrej Zary wrote:

> pi->pardev is struct pardevice *, no need to cast it to the same type.
> Also clean up the return mess.
>
> Signed-off-by: Ondrej Zary <[email protected]>

Reviewed-by: Sergey Shtylyov <[email protected]>

[...]

MBR, Sergey