2023-03-08 08:34:03

by Neil Armstrong

Subject: [PATCH 0/3] arm64: dts: qcom: sm8550: various DT fixes

Various DT fixes to enhance redability and unify the DT style.

No functionnal changes expected.

Signed-off-by: Neil Armstrong <[email protected]>
---
Neil Armstrong (3):
arm64: dts: qcom: sm8550: replace 0x0 to 0
arm64: dts: qcom: sm8550: fix qup_spi0_cs node
arm64: dts: qcom: sm8550: misc style fixes

arch/arm64/boot/dts/qcom/sm8550.dtsi | 80 ++++++++++++++++++------------------
1 file changed, 41 insertions(+), 39 deletions(-)
---
base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
change-id: 20230308-topic-sm8550-upstream-dt-fixups-8fd478197c72

Best regards,
--
Neil Armstrong <[email protected]>

2023-03-08 08:34:08

by Neil Armstrong

Subject: [PATCH 2/3] arm64: dts: qcom: sm8550: fix qup_spi0_cs node

The node is incomplete and doesn't need a subnode, add the missing
properties and move everything to the root of qup-spi0-cs-state node.

Fixes: ffc50b2d3828 ("arm64: dts: qcom: Add base SM8550 dtsi")
Signed-off-by: Neil Armstrong <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8550.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index fe8b92954550..c25c68257412 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -2807,10 +2807,10 @@ qup_i2c15_data_clk: qup-i2c15-data-clk-state {
};

qup_spi0_cs: qup-spi0-cs-state {
- cs-pins {
- pins = "gpio31";
- function = "qup1_se0";
- };
+ pins = "gpio31";
+ function = "qup1_se0";
+ drive-strength = <6>;
+ bias-disable;
};

qup_spi0_data_clk: qup-spi0-data-clk-state {

--
2.34.1

2023-03-08 08:34:13

by Neil Armstrong

Subject: [PATCH 3/3] arm64: dts: qcom: sm8550: misc style fixes

Miscellaneous DT fixes to remove spurious blank line and enhance readability.

Fixes: ffc50b2d3828 ("arm64: dts: qcom: Add base SM8550 dtsi")
Fixes: d7da51db5b81 ("arm64: dts: qcom: sm8550: add display hardware devices")
Signed-off-by: Neil Armstrong <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8550.dtsi | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index c25c68257412..6208a6196090 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -412,7 +412,6 @@ xbl_sc_mem: xbl-sc-region@d8100000 {
no-map;
};

-
hyp_tags_reserved_mem: hyp-tags-reserved-region@811d0000 {
reg = <0 0x811d0000 0 0x30000>;
no-map;
@@ -2210,7 +2209,8 @@ mdss_dsi0: dsi@ae94000 {

assigned-clocks = <&dispcc DISP_CC_MDSS_BYTE0_CLK_SRC>,
<&dispcc DISP_CC_MDSS_PCLK0_CLK_SRC>;
- assigned-clock-parents = <&mdss_dsi0_phy 0>, <&mdss_dsi0_phy 1>;
+ assigned-clock-parents = <&mdss_dsi0_phy 0>,
+ <&mdss_dsi0_phy 1>;

operating-points-v2 = <&mdss_dsi_opp_table>;

@@ -2302,8 +2302,10 @@ mdss_dsi1: dsi@ae96000 {

power-domains = <&rpmhpd SM8550_MMCX>;

- assigned-clocks = <&dispcc DISP_CC_MDSS_BYTE1_CLK_SRC>, <&dispcc DISP_CC_MDSS_PCLK1_CLK_SRC>;
- assigned-clock-parents = <&mdss_dsi1_phy 0>, <&mdss_dsi1_phy 1>;
+ assigned-clocks = <&dispcc DISP_CC_MDSS_BYTE1_CLK_SRC>,
+ <&dispcc DISP_CC_MDSS_PCLK1_CLK_SRC>;
+ assigned-clock-parents = <&mdss_dsi1_phy 0>,
+ <&mdss_dsi1_phy 1>;

operating-points-v2 = <&mdss_dsi_opp_table>;

@@ -3171,7 +3173,7 @@ apps_smmu: iommu@15000000 {

intc: interrupt-controller@17100000 {
compatible = "arm,gic-v3";
- reg = <0 0x17100000 0 0x10000>, /* GICD */
+ reg = <0 0x17100000 0 0x10000>, /* GICD */
<0 0x17180000 0 0x200000>; /* GICR * 8 */
ranges;
#interrupt-cells = <3>;

--
2.34.1

2023-03-08 09:58:15

by Konrad Dybcio

Subject: Re: [PATCH 2/3] arm64: dts: qcom: sm8550: fix qup_spi0_cs node

On 8.03.2023 09:32, Neil Armstrong wrote:
> The node is incomplete and doesn't need a subnode, add the missing
> properties and move everything to the root of qup-spi0-cs-state node.
>
> Fixes: ffc50b2d3828 ("arm64: dts: qcom: Add base SM8550 dtsi")
> Signed-off-by: Neil Armstrong <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sm8550.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> index fe8b92954550..c25c68257412 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> @@ -2807,10 +2807,10 @@ qup_i2c15_data_clk: qup-i2c15-data-clk-state {
> };
>
> qup_spi0_cs: qup-spi0-cs-state {
> - cs-pins {
> - pins = "gpio31";
> - function = "qup1_se0";
> - };
> + pins = "gpio31";
> + function = "qup1_se0";
> + drive-strength = <6>;
> + bias-disable;
> };
>
> qup_spi0_data_clk: qup-spi0-data-clk-state {
>

2023-03-08 09:59:27

by Konrad Dybcio

Subject: Re: [PATCH 3/3] arm64: dts: qcom: sm8550: misc style fixes

On 8.03.2023 09:32, Neil Armstrong wrote:
> Miscellaneous DT fixes to remove spurious blank line and enhance readability.
>
> Fixes: ffc50b2d3828 ("arm64: dts: qcom: Add base SM8550 dtsi")
> Fixes: d7da51db5b81 ("arm64: dts: qcom: sm8550: add display hardware devices")
> Signed-off-by: Neil Armstrong <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sm8550.dtsi | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> index c25c68257412..6208a6196090 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> @@ -412,7 +412,6 @@ xbl_sc_mem: xbl-sc-region@d8100000 {
> no-map;
> };
>
> -
> hyp_tags_reserved_mem: hyp-tags-reserved-region@811d0000 {
> reg = <0 0x811d0000 0 0x30000>;
> no-map;
> @@ -2210,7 +2209,8 @@ mdss_dsi0: dsi@ae94000 {
>
> assigned-clocks = <&dispcc DISP_CC_MDSS_BYTE0_CLK_SRC>,
> <&dispcc DISP_CC_MDSS_PCLK0_CLK_SRC>;
> - assigned-clock-parents = <&mdss_dsi0_phy 0>, <&mdss_dsi0_phy 1>;
> + assigned-clock-parents = <&mdss_dsi0_phy 0>,
> + <&mdss_dsi0_phy 1>;
>
> operating-points-v2 = <&mdss_dsi_opp_table>;
>
> @@ -2302,8 +2302,10 @@ mdss_dsi1: dsi@ae96000 {
>
> power-domains = <&rpmhpd SM8550_MMCX>;
>
> - assigned-clocks = <&dispcc DISP_CC_MDSS_BYTE1_CLK_SRC>, <&dispcc DISP_CC_MDSS_PCLK1_CLK_SRC>;
> - assigned-clock-parents = <&mdss_dsi1_phy 0>, <&mdss_dsi1_phy 1>;
> + assigned-clocks = <&dispcc DISP_CC_MDSS_BYTE1_CLK_SRC>,
> + <&dispcc DISP_CC_MDSS_PCLK1_CLK_SRC>;
> + assigned-clock-parents = <&mdss_dsi1_phy 0>,
> + <&mdss_dsi1_phy 1>;
>
> operating-points-v2 = <&mdss_dsi_opp_table>;
>
> @@ -3171,7 +3173,7 @@ apps_smmu: iommu@15000000 {
>
> intc: interrupt-controller@17100000 {
> compatible = "arm,gic-v3";
> - reg = <0 0x17100000 0 0x10000>, /* GICD */
> + reg = <0 0x17100000 0 0x10000>, /* GICD */
> <0 0x17180000 0 0x200000>; /* GICR * 8 */
> ranges;
> #interrupt-cells = <3>;
>

2023-03-16 03:18:37

by Bjorn Andersson

Subject: Re: (subset) [PATCH 0/3] arm64: dts: qcom: sm8550: various DT fixes

On Wed, 08 Mar 2023 09:32:51 +0100, Neil Armstrong wrote:
> Various DT fixes to enhance redability and unify the DT style.
>
> No functionnal changes expected.
>
>

Applied, thanks!

[2/3] arm64: dts: qcom: sm8550: fix qup_spi0_cs node
commit: 7629c7a525d163f2a3a08e260a69ff25163ab357
[3/3] arm64: dts: qcom: sm8550: misc style fixes
commit: f03908b23f84ecd49f12facf4acf34c3ad24f27a

Best regards,
--
Bjorn Andersson <[email protected]>