2023-03-08 12:31:39

by Krzysztof Kozlowski

Subject: [PATCH] arm64: dts: qcom: sm8450: correct WSA2 assigned clocks

The WSA2 assigned-clocks were copied from WSA, but the WSA2 uses its
own.

Fixes: 14341e76dbc7 ("arm64: dts: qcom: sm8450: add Soundwire and LPASS")
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index 42833188a257..a315c0a61c5f 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -2142,8 +2142,8 @@ wsa2macro: codec@31e0000 {
<&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
<&vamacro>;
clock-names = "mclk", "npl", "macro", "dcodec", "fsgen";
- assigned-clocks = <&q6prmcc LPASS_CLK_ID_WSA_CORE_TX_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
- <&q6prmcc LPASS_CLK_ID_WSA_CORE_TX_2X_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
+ assigned-clocks = <&q6prmcc LPASS_CLK_ID_WSA2_CORE_TX_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+ <&q6prmcc LPASS_CLK_ID_WSA2_CORE_TX_2X_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
assigned-clock-rates = <19200000>, <19200000>;

#clock-cells = <0>;
--
2.34.1

2023-03-08 12:35:09

by Konrad Dybcio

Subject: Re: [PATCH] arm64: dts: qcom: sm8450: correct WSA2 assigned clocks

On 8.03.2023 13:31, Krzysztof Kozlowski wrote:
> The WSA2 assigned-clocks were copied from WSA, but the WSA2 uses its
> own.
>
> Fixes: 14341e76dbc7 ("arm64: dts: qcom: sm8450: add Soundwire and LPASS")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> index 42833188a257..a315c0a61c5f 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> @@ -2142,8 +2142,8 @@ wsa2macro: codec@31e0000 {
> <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> <&vamacro>;
> clock-names = "mclk", "npl", "macro", "dcodec", "fsgen";
> - assigned-clocks = <&q6prmcc LPASS_CLK_ID_WSA_CORE_TX_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> - <&q6prmcc LPASS_CLK_ID_WSA_CORE_TX_2X_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
> + assigned-clocks = <&q6prmcc LPASS_CLK_ID_WSA2_CORE_TX_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> + <&q6prmcc LPASS_CLK_ID_WSA2_CORE_TX_2X_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
> assigned-clock-rates = <19200000>, <19200000>;
>
> #clock-cells = <0>;

2023-03-15 23:33:53

by Bjorn Andersson

Subject: Re: [PATCH] arm64: dts: qcom: sm8450: correct WSA2 assigned clocks

On Wed, 8 Mar 2023 13:31:29 +0100, Krzysztof Kozlowski wrote:
> The WSA2 assigned-clocks were copied from WSA, but the WSA2 uses its
> own.
>
>

Applied, thanks!

[1/1] arm64: dts: qcom: sm8450: correct WSA2 assigned clocks
commit: 6df6fab9320bc9ebdf50136a01e7bf0ee5984c62

Best regards,
--
Bjorn Andersson <[email protected]>