2023-03-08 14:28:29

by Krzysztof Kozlowski

Subject: [PATCH] arm64: dts: qcom: sm8450-hdk: use recommended drive strength for speaker SD_N

Downstream DTS (and sc8280xp-lenovo-thinkpad-x13s with the same
speakers) uses 16 mA drive strength for the WSA8835 speaker SD_N
reset/shutdown pin. Use the same for HDK8450, as it is seem the
recommended value.

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Not adding Fixes tag because 4 mA seems to work, so this is just
choosing safer value, based on downstream DTS.
---
arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
index 9fa1a83d9554..e04de4bb7fae 100644
--- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
@@ -754,7 +754,7 @@ &tlmm {
spkr_1_sd_n_active: spkr-1-sd-n-active-state {
pins = "gpio1";
function = "gpio";
- drive-strength = <4>;
+ drive-strength = <16>;
bias-disable;
output-low;
};
@@ -762,7 +762,7 @@ spkr_1_sd_n_active: spkr-1-sd-n-active-state {
spkr_2_sd_n_active: spkr-2-sd-n-active-state {
pins = "gpio89";
function = "gpio";
- drive-strength = <4>;
+ drive-strength = <16>;
bias-disable;
output-low;
};
--
2.34.1

2023-03-22 14:45:34

by Bjorn Andersson

Subject: Re: [PATCH] arm64: dts: qcom: sm8450-hdk: use recommended drive strength for speaker SD_N

On Wed, 8 Mar 2023 15:27:12 +0100, Krzysztof Kozlowski wrote:
> Downstream DTS (and sc8280xp-lenovo-thinkpad-x13s with the same
> speakers) uses 16 mA drive strength for the WSA8835 speaker SD_N
> reset/shutdown pin. Use the same for HDK8450, as it is seem the
> recommended value.
>
>

Applied, thanks!

[1/1] arm64: dts: qcom: sm8450-hdk: use recommended drive strength for speaker SD_N
commit: 7c2c4c9decf6f4604fe15a1db2da7c1250b3e9e5

Best regards,
--
Bjorn Andersson <[email protected]>