2023-03-08 18:33:30

by Krzysztof Kozlowski

Subject: [PATCH 1/2] arm64: dts: qcom: sm8450-hdk: use precise WCD9385 compatible

The HDK8450 uses WCD9385 audio codec, so use precise compatible, even
though WCD9380 and WCD9385 are both compatible.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
index e04de4bb7fae..9cd1d1bd86cb 100644
--- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
@@ -25,7 +25,7 @@ aliases {
};

wcd938x: audio-codec {
- compatible = "qcom,wcd9380-codec";
+ compatible = "qcom,wcd9385-codec";

pinctrl-names = "default";
pinctrl-0 = <&wcd_default>;
--
2.34.1

2023-03-08 18:33:34

by Krzysztof Kozlowski

Subject: [PATCH 2/2] arm64: dts: qcom: sm8450-hdk: align WCD9385 reset pin with downstream config

Downstream DTS uses 16 mA drive strength for the WCD9385 audio codec
RESET_N reset pin. It also pulls the pin down in shutdown mode, thus it
is more like a shutdown pin, not a reset. Use the same settings here
for HDK8450 and keep the WCD9385 by default in powered off (so pin as
low). Align the name of pin configuration node with other pins in the
DTS.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
index 9cd1d1bd86cb..4020e54e16f5 100644
--- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
@@ -767,9 +767,11 @@ spkr_2_sd_n_active: spkr-2-sd-n-active-state {
output-low;
};

- wcd_default: wcd-default-state {
+ wcd_default: wcd-reset-n-active-state {
pins = "gpio43";
function = "gpio";
+ drive-strength = <16>;
bias-disable;
+ output-low;
};
};
--
2.34.1

2023-03-08 20:57:30

by Konrad Dybcio

Subject: Re: [PATCH 1/2] arm64: dts: qcom: sm8450-hdk: use precise WCD9385 compatible

On 8.03.2023 19:33, Krzysztof Kozlowski wrote:
> The HDK8450 uses WCD9385 audio codec, so use precise compatible, even
> though WCD9380 and WCD9385 are both compatible.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> index e04de4bb7fae..9cd1d1bd86cb 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> @@ -25,7 +25,7 @@ aliases {
> };
>
> wcd938x: audio-codec {
> - compatible = "qcom,wcd9380-codec";
> + compatible = "qcom,wcd9385-codec";
>
> pinctrl-names = "default";
> pinctrl-0 = <&wcd_default>;

2023-03-08 20:58:57

by Konrad Dybcio

Subject: Re: [PATCH 2/2] arm64: dts: qcom: sm8450-hdk: align WCD9385 reset pin with downstream config

On 8.03.2023 19:33, Krzysztof Kozlowski wrote:
> Downstream DTS uses 16 mA drive strength for the WCD9385 audio codec
> RESET_N reset pin. It also pulls the pin down in shutdown mode, thus it
> is more like a shutdown pin, not a reset. Use the same settings here
> for HDK8450 and keep the WCD9385 by default in powered off (so pin as
> low). Align the name of pin configuration node with other pins in the
> DTS.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> index 9cd1d1bd86cb..4020e54e16f5 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> @@ -767,9 +767,11 @@ spkr_2_sd_n_active: spkr-2-sd-n-active-state {
> output-low;
> };
>
> - wcd_default: wcd-default-state {
> + wcd_default: wcd-reset-n-active-state {
> pins = "gpio43";
> function = "gpio";
> + drive-strength = <16>;
> bias-disable;
> + output-low;
> };
> };

2023-03-22 14:44:55

by Bjorn Andersson

Subject: Re: (subset) [PATCH 1/2] arm64: dts: qcom: sm8450-hdk: use precise WCD9385 compatible

On Wed, 8 Mar 2023 19:33:16 +0100, Krzysztof Kozlowski wrote:
> The HDK8450 uses WCD9385 audio codec, so use precise compatible, even
> though WCD9380 and WCD9385 are both compatible.
>
>

Applied, thanks!

[1/2] arm64: dts: qcom: sm8450-hdk: use precise WCD9385 compatible
commit: f0d0966f87f9c38b74619bf7f0345f368af3a4c1
[2/2] arm64: dts: qcom: sm8450-hdk: align WCD9385 reset pin with downstream config
commit: 6b2777fff8a9942cdcee82ae3f17d7f483a1e18c

Best regards,
--
Bjorn Andersson <[email protected]>