2023-03-09 08:07:59

by Zheng Wang

Subject: [PATCH] Bluetooth: btsdio: fix use after free bug in btsdio_remove due to unfinished work

In btsdio_probe, &data->work was bound with btsdio_work.In
btsdio_send_frame, it was started by schedule_work.

If we call btsdio_remove with an unfinished job, there may
be a race condition and cause UAF bug on hdev.

Fixes: ddbaf13e3609 ("[Bluetooth] Add generic driver for Bluetooth SDIO devices")
Signed-off-by: Zheng Wang <[email protected]>
---
drivers/bluetooth/btsdio.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/btsdio.c b/drivers/bluetooth/btsdio.c
index 795be33f2892..02893600db39 100644
--- a/drivers/bluetooth/btsdio.c
+++ b/drivers/bluetooth/btsdio.c
@@ -354,6 +354,7 @@ static void btsdio_remove(struct sdio_func *func)

BT_DBG("func %p", func);

+ cancel_work_sync(&data->work);
if (!data)
return;

--
2.25.1

2023-03-14 23:10:41

by patchwork-bot+bluetooth

Subject: Re: [PATCH] Bluetooth: btsdio: fix use after free bug in btsdio_remove due to unfinished work

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Thu, 9 Mar 2023 16:07:39 +0800 you wrote:
> In btsdio_probe, &data->work was bound with btsdio_work.In
> btsdio_send_frame, it was started by schedule_work.
>
> If we call btsdio_remove with an unfinished job, there may
> be a race condition and cause UAF bug on hdev.
>
> Fixes: ddbaf13e3609 ("[Bluetooth] Add generic driver for Bluetooth SDIO devices")
> Signed-off-by: Zheng Wang <[email protected]>
>
> [...]

Here is the summary with links:
- Bluetooth: btsdio: fix use after free bug in btsdio_remove due to unfinished work
https://git.kernel.org/bluetooth/bluetooth-next/c/f132c2d13088

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html