2023-03-09 14:41:26

by Geert Uytterhoeven

Subject: [PATCH v2] sh: mach-x3proto: Add missing #include <linux/gpio/driver.h>

shx3_defconfig:

arch/sh/boards/mach-x3proto/setup.c: In function ‘x3proto_devices_setup’:
arch/sh/boards/mach-x3proto/setup.c:246:62: error: invalid use of undefined type ‘struct gpio_chip’
246 | baseboard_buttons[i].gpio = x3proto_gpio_chip.base + i;
| ^

Fix this by replacing the include of the legacy <linux/gpio.h> by
<linux/gpio/driver.h>.

Reported-by: Linux Kernel Functional Testing <[email protected]>
Link: https://lore.kernel.org/r/CA+G9fYs7suzGsEDK40G0pzxXyR1o2V4Pn-oy1owTsTWRVEVHog@mail.gmail.com
Fixes: 21d9526d13b5467b ("gpiolib: Make the legacy <linux/gpio.h> consumer-only")
Signed-off-by: Geert Uytterhoeven <[email protected]>
Reviewed-by: Linus Walleij <[email protected]>
---
v2:
- Add Reviewed-by,
- Drop inclusion of <linux/gpio.h>.
---
arch/sh/boards/mach-x3proto/setup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/sh/boards/mach-x3proto/setup.c b/arch/sh/boards/mach-x3proto/setup.c
index 95b85f2e13dda75b..ca2802d3056503cb 100644
--- a/arch/sh/boards/mach-x3proto/setup.c
+++ b/arch/sh/boards/mach-x3proto/setup.c
@@ -16,7 +16,7 @@
#include <linux/input.h>
#include <linux/usb/r8a66597.h>
#include <linux/usb/m66592.h>
-#include <linux/gpio.h>
+#include <linux/gpio/driver.h>
#include <linux/gpio_keys.h>
#include <mach/ilsel.h>
#include <mach/hardware.h>
--
2.34.1

2023-03-09 17:47:07

by Andy Shevchenko

Subject: Re: [PATCH v2] sh: mach-x3proto: Add missing #include <linux/gpio/driver.h>

On Thu, Mar 09, 2023 at 03:41:13PM +0100, Geert Uytterhoeven wrote:
> shx3_defconfig:
>
> arch/sh/boards/mach-x3proto/setup.c: In function ‘x3proto_devices_setup’:
> arch/sh/boards/mach-x3proto/setup.c:246:62: error: invalid use of undefined type ‘struct gpio_chip’
> 246 | baseboard_buttons[i].gpio = x3proto_gpio_chip.base + i;
> | ^
>
> Fix this by replacing the include of the legacy <linux/gpio.h> by
> <linux/gpio/driver.h>.

Pushed to my review and testing queue, thanks!

--
With Best Regards,
Andy Shevchenko