2023-03-09 11:16:50

by Johan Hovold

[permalink] [raw]
Subject: [PATCH] firmware: qcom: scm: fix bogus irq error at probe

A recent commit added support for an optional interrupt which is only
available on some platforms.

Stop spamming the logs with bogus error messages on platforms that do
not use this new optional resource:

qcom_scm firmware:scm: error -ENXIO: IRQ index 0 not found

Fixes: 6bf325992236 ("firmware: qcom: scm: Add wait-queue handling logic")
Cc: Guru Das Srinagesh <[email protected]>
Cc: Sibi Sankar <[email protected]>
Signed-off-by: Johan Hovold <[email protected]>
---
drivers/firmware/qcom_scm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
index 468d4d5ab550..b1e11f85b805 100644
--- a/drivers/firmware/qcom_scm.c
+++ b/drivers/firmware/qcom_scm.c
@@ -1479,7 +1479,7 @@ static int qcom_scm_probe(struct platform_device *pdev)

init_completion(&__scm->waitq_comp);

- irq = platform_get_irq(pdev, 0);
+ irq = platform_get_irq_optional(pdev, 0);
if (irq < 0) {
if (irq != -ENXIO)
return irq;
--
2.39.2



2023-03-09 11:51:09

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH] firmware: qcom: scm: fix bogus irq error at probe



On 9.03.2023 12:12, Johan Hovold wrote:
> A recent commit added support for an optional interrupt which is only
> available on some platforms.
>
> Stop spamming the logs with bogus error messages on platforms that do
> not use this new optional resource:
>
> qcom_scm firmware:scm: error -ENXIO: IRQ index 0 not found
>
> Fixes: 6bf325992236 ("firmware: qcom: scm: Add wait-queue handling logic")
> Cc: Guru Das Srinagesh <[email protected]>
> Cc: Sibi Sankar <[email protected]>
> Signed-off-by: Johan Hovold <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> drivers/firmware/qcom_scm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> index 468d4d5ab550..b1e11f85b805 100644
> --- a/drivers/firmware/qcom_scm.c
> +++ b/drivers/firmware/qcom_scm.c
> @@ -1479,7 +1479,7 @@ static int qcom_scm_probe(struct platform_device *pdev)
>
> init_completion(&__scm->waitq_comp);
>
> - irq = platform_get_irq(pdev, 0);
> + irq = platform_get_irq_optional(pdev, 0);
> if (irq < 0) {
> if (irq != -ENXIO)
> return irq;

2023-03-09 17:57:21

by Guru Das Srinagesh

[permalink] [raw]
Subject: Re: [PATCH] firmware: qcom: scm: fix bogus irq error at probe

On Mar 09 2023 12:12, Johan Hovold wrote:
> A recent commit added support for an optional interrupt which is only
> available on some platforms.
>
> Stop spamming the logs with bogus error messages on platforms that do
> not use this new optional resource:
>
> qcom_scm firmware:scm: error -ENXIO: IRQ index 0 not found
>
> Fixes: 6bf325992236 ("firmware: qcom: scm: Add wait-queue handling logic")
> Cc: Guru Das Srinagesh <[email protected]>
> Cc: Sibi Sankar <[email protected]>
> Signed-off-by: Johan Hovold <[email protected]>

Acked-by: Guru Das Srinagesh <[email protected]>

Thanks for catching this!

> ---
> drivers/firmware/qcom_scm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> index 468d4d5ab550..b1e11f85b805 100644
> --- a/drivers/firmware/qcom_scm.c
> +++ b/drivers/firmware/qcom_scm.c
> @@ -1479,7 +1479,7 @@ static int qcom_scm_probe(struct platform_device *pdev)
>
> init_completion(&__scm->waitq_comp);
>
> - irq = platform_get_irq(pdev, 0);
> + irq = platform_get_irq_optional(pdev, 0);
> if (irq < 0) {
> if (irq != -ENXIO)
> return irq;
> --
> 2.39.2
>

2023-03-09 19:03:56

by Steev Klimaszewski

[permalink] [raw]
Subject: Re: [PATCH] firmware: qcom: scm: fix bogus irq error at probe

On Thu, Mar 9, 2023 at 5:16 AM Johan Hovold <[email protected]> wrote:
>
> A recent commit added support for an optional interrupt which is only
> available on some platforms.
>
> Stop spamming the logs with bogus error messages on platforms that do
> not use this new optional resource:
>
> qcom_scm firmware:scm: error -ENXIO: IRQ index 0 not found
>
> Fixes: 6bf325992236 ("firmware: qcom: scm: Add wait-queue handling logic")
> Cc: Guru Das Srinagesh <[email protected]>
> Cc: Sibi Sankar <[email protected]>
> Signed-off-by: Johan Hovold <[email protected]>
> ---
> drivers/firmware/qcom_scm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> index 468d4d5ab550..b1e11f85b805 100644
> --- a/drivers/firmware/qcom_scm.c
> +++ b/drivers/firmware/qcom_scm.c
> @@ -1479,7 +1479,7 @@ static int qcom_scm_probe(struct platform_device *pdev)
>
> init_completion(&__scm->waitq_comp);
>
> - irq = platform_get_irq(pdev, 0);
> + irq = platform_get_irq_optional(pdev, 0);
> if (irq < 0) {
> if (irq != -ENXIO)
> return irq;
> --
> 2.39.2
>

Thank you!
Tested on the Thinkpad X13s
Tested-by: Steev Klimaszewski <[email protected]> # Thinkpad X13s

2023-03-10 02:59:32

by Sibi Sankar

[permalink] [raw]
Subject: Re: [PATCH] firmware: qcom: scm: fix bogus irq error at probe

Hey Johan,

Thanks for the fix.

On 3/9/23 16:42, Johan Hovold wrote:
> A recent commit added support for an optional interrupt which is only
> available on some platforms.
>
> Stop spamming the logs with bogus error messages on platforms that do
> not use this new optional resource:
>
> qcom_scm firmware:scm: error -ENXIO: IRQ index 0 not found
>
> Fixes: 6bf325992236 ("firmware: qcom: scm: Add wait-queue handling logic")
> Cc: Guru Das Srinagesh <[email protected]>
> Cc: Sibi Sankar <[email protected]>
> Signed-off-by: Johan Hovold <[email protected]>

Reviewed-by: Sibi Sankar <[email protected]>

> ---
> drivers/firmware/qcom_scm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> index 468d4d5ab550..b1e11f85b805 100644
> --- a/drivers/firmware/qcom_scm.c
> +++ b/drivers/firmware/qcom_scm.c
> @@ -1479,7 +1479,7 @@ static int qcom_scm_probe(struct platform_device *pdev)
>
> init_completion(&__scm->waitq_comp);
>
> - irq = platform_get_irq(pdev, 0);
> + irq = platform_get_irq_optional(pdev, 0);
> if (irq < 0) {
> if (irq != -ENXIO)
> return irq;

2023-03-15 23:33:00

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] firmware: qcom: scm: fix bogus irq error at probe

On Thu, 9 Mar 2023 12:12:09 +0100, Johan Hovold wrote:
> A recent commit added support for an optional interrupt which is only
> available on some platforms.
>
> Stop spamming the logs with bogus error messages on platforms that do
> not use this new optional resource:
>
> qcom_scm firmware:scm: error -ENXIO: IRQ index 0 not found
>
> [...]

Applied, thanks!

[1/1] firmware: qcom: scm: fix bogus irq error at probe
commit: f3d0fbad6765da25de7ecf6481af9b6ddb0b3793

Best regards,
--
Bjorn Andersson <[email protected]>