2023-03-10 14:00:43

by Arnd Bergmann

Subject: [PATCH] platform/x86: x86-android-tablets: add CONFIG_PMIC_OPREGION dependency

From: Arnd Bergmann <[email protected]>

The newly added call to intel_soc_pmic_exec_mipi_pmic_seq_element()
requires that function to be defined:

x86_64-linux-ld: drivers/platform/x86/x86-android-tablets/lenovo.o: in function `lenovo_yt3_init':
lenovo.c:(.init.text+0x72): undefined reference to `intel_soc_pmic_exec_mipi_pmic_seq_element'
x86_64-linux-ld: lenovo.c:(.init.text+0x8b): undefined reference to `intel_soc_pmic_exec_mipi_pmic_seq_element'

Fixes: 9b1d2662b8c5 ("platform/x86: x86-android-tablets: Add touchscreen support for Lenovo Yoga Tab 3 Pro YT3-X90F")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/platform/x86/x86-android-tablets/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/x86-android-tablets/Kconfig b/drivers/platform/x86/x86-android-tablets/Kconfig
index 2b3daca5380b..c31e4df34f80 100644
--- a/drivers/platform/x86/x86-android-tablets/Kconfig
+++ b/drivers/platform/x86/x86-android-tablets/Kconfig
@@ -6,6 +6,7 @@
config X86_ANDROID_TABLETS
tristate "X86 Android tablet support"
depends on I2C && SPI && SERIAL_DEV_BUS && ACPI && EFI && GPIOLIB
+ depends on PMIC_OPREGION
help
X86 tablets which ship with Android as (part of) the factory image
typically have various problems with their DSDTs. The factory kernels
--
2.39.2

2023-03-10 14:39:43

by Hans de Goede

Subject: Re: [PATCH] platform/x86: x86-android-tablets: add CONFIG_PMIC_OPREGION dependency

Hi Arnd,

On 3/10/23 15:00, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> The newly added call to intel_soc_pmic_exec_mipi_pmic_seq_element()
> requires that function to be defined:
>
> x86_64-linux-ld: drivers/platform/x86/x86-android-tablets/lenovo.o: in function `lenovo_yt3_init':
> lenovo.c:(.init.text+0x72): undefined reference to `intel_soc_pmic_exec_mipi_pmic_seq_element'
> x86_64-linux-ld: lenovo.c:(.init.text+0x8b): undefined reference to `intel_soc_pmic_exec_mipi_pmic_seq_element'
>
> Fixes: 9b1d2662b8c5 ("platform/x86: x86-android-tablets: Add touchscreen support for Lenovo Yoga Tab 3 Pro YT3-X90F")
> Signed-off-by: Arnd Bergmann <[email protected]>

Thanks, but this is a dup with:

https://patchwork.kernel.org/project/platform-driver-x86/patch/[email protected]/

I just did not get around to pushing that out to pdx86/for-next yet ...

Regards,

Hans


> ---
> drivers/platform/x86/x86-android-tablets/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/x86-android-tablets/Kconfig b/drivers/platform/x86/x86-android-tablets/Kconfig
> index 2b3daca5380b..c31e4df34f80 100644
> --- a/drivers/platform/x86/x86-android-tablets/Kconfig
> +++ b/drivers/platform/x86/x86-android-tablets/Kconfig
> @@ -6,6 +6,7 @@
> config X86_ANDROID_TABLETS
> tristate "X86 Android tablet support"
> depends on I2C && SPI && SERIAL_DEV_BUS && ACPI && EFI && GPIOLIB
> + depends on PMIC_OPREGION
> help
> X86 tablets which ship with Android as (part of) the factory image
> typically have various problems with their DSDTs. The factory kernels