2023-03-11 09:47:44

by Krzysztof Kozlowski

Subject: [PATCH] rtc: omap: include header for omap_rtc_power_off_program prototype

Non-static functions should have a prototype:

drivers/rtc/rtc-omap.c:410:5: error: no previous prototype for ‘omap_rtc_power_off_program’ [-Werror=missing-prototypes]

Fixes: 6256f7f7f217 ("rtc: OMAP: Add support for rtc-only mode")
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/rtc/rtc-omap.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
index 4d4f3b1a7309..73634a3ccfd3 100644
--- a/drivers/rtc/rtc-omap.c
+++ b/drivers/rtc/rtc-omap.c
@@ -25,6 +25,7 @@
#include <linux/platform_device.h>
#include <linux/pm_runtime.h>
#include <linux/rtc.h>
+#include <linux/rtc/rtc-omap.h>

/*
* The OMAP RTC is a year/month/day/hours/minutes/seconds BCD clock
--
2.34.1

2023-03-17 22:25:21

by Alexandre Belloni

Subject: Re: [PATCH] rtc: omap: include header for omap_rtc_power_off_program prototype

On Sat, 11 Mar 2023 10:40:21 +0100, Krzysztof Kozlowski wrote:
> Non-static functions should have a prototype:
>
> drivers/rtc/rtc-omap.c:410:5: error: no previous prototype for ‘omap_rtc_power_off_program’ [-Werror=missing-prototypes]
>
>

Applied, thanks!

[1/1] rtc: omap: include header for omap_rtc_power_off_program prototype
commit: f69c2b5420497b7a54181ce170d682cbeb1f119f

Best regards,

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com