2023-03-12 16:16:09

by Uwe Kleine-König

Subject: [PATCH 03/30] clk: xilinx: Drop if block with always false condition

xvcu_remove() is only called for a device after after xvcu_probe()
completed successfully. In that case dev_set_drvdata() was called for
that device with a non-NULL parameter, so platform_get_drvdata() won't
return NULL and the if condition is never true.

Drop the if, preparing a conversion to make platform driver's remove
callback return void.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/clk/xilinx/xlnx_vcu.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/clk/xilinx/xlnx_vcu.c b/drivers/clk/xilinx/xlnx_vcu.c
index d66b1315114e..54b44debfd3e 100644
--- a/drivers/clk/xilinx/xlnx_vcu.c
+++ b/drivers/clk/xilinx/xlnx_vcu.c
@@ -707,8 +707,6 @@ static int xvcu_remove(struct platform_device *pdev)
struct xvcu_device *xvcu;

xvcu = platform_get_drvdata(pdev);
- if (!xvcu)
- return -ENODEV;

xvcu_unregister_clock_provider(xvcu);

--
2.39.1

2023-03-29 02:37:40

by Stephen Boyd

Subject: Re: [PATCH 03/30] clk: xilinx: Drop if block with always false condition

Quoting Uwe Kleine-König (2023-03-12 09:14:45)
> xvcu_remove() is only called for a device after after xvcu_probe()
> completed successfully. In that case dev_set_drvdata() was called for
> that device with a non-NULL parameter, so platform_get_drvdata() won't
> return NULL and the if condition is never true.
>
> Drop the if, preparing a conversion to make platform driver's remove
> callback return void.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>
> ---

Applied to clk-next