2023-03-10 23:02:27

by Luis Chamberlain

Subject: [PATCH] xfs: simplify two-level sysctl registration for xfs_table

There is no need to declare two tables to just create directories,
this can be easily be done with a prefix path with register_sysctl().

Simplify this registration.

Signed-off-by: Luis Chamberlain <[email protected]>
---

This is not clear to some so I've updated the docs for the sysctl
registration here:

https://lore.kernel.org/all/[email protected]/T/#u

fs/xfs/xfs_sysctl.c | 20 +-------------------
1 file changed, 1 insertion(+), 19 deletions(-)

diff --git a/fs/xfs/xfs_sysctl.c b/fs/xfs/xfs_sysctl.c
index 546a6cd96729..fade33735393 100644
--- a/fs/xfs/xfs_sysctl.c
+++ b/fs/xfs/xfs_sysctl.c
@@ -210,28 +210,10 @@ static struct ctl_table xfs_table[] = {
{}
};

-static struct ctl_table xfs_dir_table[] = {
- {
- .procname = "xfs",
- .mode = 0555,
- .child = xfs_table
- },
- {}
-};
-
-static struct ctl_table xfs_root_table[] = {
- {
- .procname = "fs",
- .mode = 0555,
- .child = xfs_dir_table
- },
- {}
-};
-
int
xfs_sysctl_register(void)
{
- xfs_table_header = register_sysctl_table(xfs_root_table);
+ xfs_table_header = register_sysctl("fs/xfs", xfs_table);
if (!xfs_table_header)
return -ENOMEM;
return 0;
--
2.39.1

2023-03-12 23:31:19

by Dave Chinner

Subject: Re: [PATCH] xfs: simplify two-level sysctl registration for xfs_table

On Fri, Mar 10, 2023 at 03:02:19PM -0800, Luis Chamberlain wrote:
> There is no need to declare two tables to just create directories,
> this can be easily be done with a prefix path with register_sysctl().
>
> Simplify this registration.
>
> Signed-off-by: Luis Chamberlain <[email protected]>
> ---
>
> This is not clear to some so I've updated the docs for the sysctl
> registration here:
>
> https://lore.kernel.org/all/[email protected]/T/#u
>
> fs/xfs/xfs_sysctl.c | 20 +-------------------
> 1 file changed, 1 insertion(+), 19 deletions(-)

Looks fine.

Reviewed-by: Dave Chinner <[email protected]>

--
Dave Chinner
[email protected]