2023-03-13 04:14:12

by Joel Selvaraj

Subject: [PATCH] scsi: core: Add BLIST_SKIP_VPD_PAGES for SKhynix H28U74301AMR

Xiaomi Poco F1(qcom/sdm845-xiaomi-beryllium*.dts) comes with a SKhynix
H28U74301AMR UFS. The sd_read_cpr operation leads to a 120 seconds timeout
making the device bootup very slow. Like the following:

[ 121.457736] sd 0:0:0:1: [sdb] tag#23 timing out command, waited 120s

Setting the BLIST_SKIP_VPD_PAGES allows the device to skip the failing
sd_read_cpr operation and boot normally.

Signed-off-by: Joel Selvaraj <[email protected]>
---
drivers/scsi/scsi_devinfo.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index c7080454aea9..bd110a93d047 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -233,6 +233,7 @@ static struct {
{"SGI", "RAID5", "*", BLIST_SPARSELUN},
{"SGI", "TP9100", "*", BLIST_REPORTLUN2},
{"SGI", "Universal Xport", "*", BLIST_NO_ULD_ATTACH},
+ {"SKhynix", "H28U74301AMR", NULL, BLIST_SKIP_VPD_PAGES},
{"IBM", "Universal Xport", "*", BLIST_NO_ULD_ATTACH},
{"SUN", "Universal Xport", "*", BLIST_NO_ULD_ATTACH},
{"DELL", "Universal Xport", "*", BLIST_NO_ULD_ATTACH},
--
2.39.2

2023-03-17 04:05:27

by Martin K. Petersen

Subject: Re: [PATCH] scsi: core: Add BLIST_SKIP_VPD_PAGES for SKhynix H28U74301AMR

On Sun, 12 Mar 2023 23:14:02 -0500, Joel Selvaraj wrote:

> Xiaomi Poco F1(qcom/sdm845-xiaomi-beryllium*.dts) comes with a SKhynix
> H28U74301AMR UFS. The sd_read_cpr operation leads to a 120 seconds timeout
> making the device bootup very slow. Like the following:
>
> [ 121.457736] sd 0:0:0:1: [sdb] tag#23 timing out command, waited 120s
>
> Setting the BLIST_SKIP_VPD_PAGES allows the device to skip the failing
> sd_read_cpr operation and boot normally.
>
> [...]

Applied to 6.3/scsi-fixes, thanks!

[1/1] scsi: core: Add BLIST_SKIP_VPD_PAGES for SKhynix H28U74301AMR
https://git.kernel.org/mkp/scsi/c/a204b490595d

--
Martin K. Petersen Oracle Linux Engineering