2023-03-14 21:10:49

by Jesse T

Subject: [PATCH v1] RISCV: CANAAN: Make K210_SYSCTL depend on CLK_K210

CLK_K210 is no longer a dependency of SOC_CANAAN,
but K210_SYSCTL depends on CLK_K210. This patch makes K210_SYSCTL
depend on CLK_K210. Also fix whitespace errors.

Reported-by: Randy Dunlap <[email protected]>
Link: https://lore.kernel.org/all/[email protected]
Fixes: 3af577f9826f ("RISC-V: stop directly selecting drivers for SOC_CANAAN")
Signed-off-by: Jesse Taube <[email protected]>
---
drivers/soc/canaan/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/soc/canaan/Kconfig b/drivers/soc/canaan/Kconfig
index 2527cf5757ec..caf3705d8917 100644
--- a/drivers/soc/canaan/Kconfig
+++ b/drivers/soc/canaan/Kconfig
@@ -2,9 +2,9 @@

config SOC_K210_SYSCTL
bool "Canaan Kendryte K210 SoC system controller"
- depends on RISCV && SOC_CANAAN && OF
+ depends on RISCV && SOC_CANAAN && OF && COMMON_CLK_K210
default SOC_CANAAN
- select PM
- select MFD_SYSCON
+ select PM
+ select MFD_SYSCON
help
Canaan Kendryte K210 SoC system controller driver.
--
2.39.0

2023-03-14 22:58:44

by Damien Le Moal

Subject: Re: [PATCH v1] RISCV: CANAAN: Make K210_SYSCTL depend on CLK_K210

On 3/15/23 06:10, Jesse Taube wrote:
> CLK_K210 is no longer a dependency of SOC_CANAAN,
> but K210_SYSCTL depends on CLK_K210. This patch makes K210_SYSCTL
> depend on CLK_K210. Also fix whitespace errors.
>
> Reported-by: Randy Dunlap <[email protected]>
> Link: https://lore.kernel.org/all/[email protected]
> Fixes: 3af577f9826f ("RISC-V: stop directly selecting drivers for SOC_CANAAN")
> Signed-off-by: Jesse Taube <[email protected]>

Reviewed-by: Damien Le Moal <[email protected]>


--
Damien Le Moal
Western Digital Research

2023-03-15 14:30:07

by Conor Dooley

Subject: Re: [PATCH v1] RISCV: CANAAN: Make K210_SYSCTL depend on CLK_K210

From: Conor Dooley <[email protected]>

On Tue, 14 Mar 2023 17:10:30 -0400, Jesse Taube wrote:
> CLK_K210 is no longer a dependency of SOC_CANAAN,
> but K210_SYSCTL depends on CLK_K210. This patch makes K210_SYSCTL
> depend on CLK_K210. Also fix whitespace errors.
>
>

Applied to riscv-soc-for-next, thanks!

[1/1] soc: canaan: Make K210_SYSCTL depend on CLK_K210
https://git.kernel.org/conor/c/49f965b6fbca63904d7397ce96066fa992f401a3

I dropped the common clk dependency down onto its own line & tweaked
the $subject a wee bit.

Thanks for the patch!