2023-03-15 19:47:43

by Daniil Tatianin

Subject: [PATCH] qed/qed_mng_tlv: correctly zero out ->min instead of ->hour

This fixes an issue where ->hour would erroneously get zeroed out
instead of ->min because of a bad copy paste.

Found by Linux Verification Center (linuxtesting.org) with the SVACE
static analysis tool.

Fixes: f240b6882211 ("qed: Add support for processing fcoe tlv request.")
Signed-off-by: Daniil Tatianin <[email protected]>
---
drivers/net/ethernet/qlogic/qed/qed_mng_tlv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_mng_tlv.c b/drivers/net/ethernet/qlogic/qed/qed_mng_tlv.c
index 6190adf965bc..f55eed092f25 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_mng_tlv.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_mng_tlv.c
@@ -422,7 +422,7 @@ qed_mfw_get_tlv_time_value(struct qed_mfw_tlv_time *p_time,
if (p_time->hour > 23)
p_time->hour = 0;
if (p_time->min > 59)
- p_time->hour = 0;
+ p_time->min = 0;
if (p_time->msec > 999)
p_time->msec = 0;
if (p_time->usec > 999)
--
2.25.1

2023-03-17 04:20:33

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] qed/qed_mng_tlv: correctly zero out ->min instead of ->hour

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

On Wed, 15 Mar 2023 22:46:18 +0300 you wrote:
> This fixes an issue where ->hour would erroneously get zeroed out
> instead of ->min because of a bad copy paste.
>
> Found by Linux Verification Center (linuxtesting.org) with the SVACE
> static analysis tool.
>
> Fixes: f240b6882211 ("qed: Add support for processing fcoe tlv request.")
> Signed-off-by: Daniil Tatianin <[email protected]>
>
> [...]

Here is the summary with links:
- qed/qed_mng_tlv: correctly zero out ->min instead of ->hour
https://git.kernel.org/netdev/net/c/470efd68a465

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html