2023-03-16 11:50:04

by Lukas Bulwahn

[permalink] [raw]
Subject: [PATCH] MIPS: ath79: remove obsolete ATH79_DEV_* configs

Commit 85b9686dae30 ("MIPS: ath79: drop platform device registration code")
removes all files arch/mips/ath79/dev-*.[ch], adjusts the Makefile, but
misses to adjust the Kconfig file. Hence, since then, the configs
ATH79_DEV_* are really dead.

Commit 3a77e0d75eed ("MIPS: ath79: drop machfiles") already removes all
configs that select ATH79_DEV_* config. So at that point, they was not a
way to enable them with a kernel build configuration.

Remove these obsolete ATH79_DEV_* configs.

Signed-off-by: Lukas Bulwahn <[email protected]>
---
arch/mips/ath79/Kconfig | 16 ----------------
1 file changed, 16 deletions(-)

diff --git a/arch/mips/ath79/Kconfig b/arch/mips/ath79/Kconfig
index 7367416642cb..04154128c4de 100644
--- a/arch/mips/ath79/Kconfig
+++ b/arch/mips/ath79/Kconfig
@@ -29,20 +29,4 @@ config SOC_QCA955X
config PCI_AR724X
def_bool n

-config ATH79_DEV_GPIO_BUTTONS
- def_bool n
-
-config ATH79_DEV_LEDS_GPIO
- def_bool n
-
-config ATH79_DEV_SPI
- def_bool n
-
-config ATH79_DEV_USB
- def_bool n
-
-config ATH79_DEV_WMAC
- depends on (SOC_AR913X || SOC_AR933X || SOC_AR934X || SOC_QCA955X)
- def_bool n
-
endif
--
2.17.1



2023-03-17 10:25:59

by Thomas Bogendoerfer

[permalink] [raw]
Subject: Re: [PATCH] MIPS: ath79: remove obsolete ATH79_DEV_* configs

On Thu, Mar 16, 2023 at 12:49:52PM +0100, Lukas Bulwahn wrote:
> Commit 85b9686dae30 ("MIPS: ath79: drop platform device registration code")
> removes all files arch/mips/ath79/dev-*.[ch], adjusts the Makefile, but
> misses to adjust the Kconfig file. Hence, since then, the configs
> ATH79_DEV_* are really dead.
>
> Commit 3a77e0d75eed ("MIPS: ath79: drop machfiles") already removes all
> configs that select ATH79_DEV_* config. So at that point, they was not a
> way to enable them with a kernel build configuration.
>
> Remove these obsolete ATH79_DEV_* configs.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>
> ---
> arch/mips/ath79/Kconfig | 16 ----------------
> 1 file changed, 16 deletions(-)

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]