2023-03-17 18:38:15

by Danila Chernetsov

Subject: [PATCH] megaraid: fix mega_cmd_done CMDID_INT_CMDS

When cmdid == CMDID_INT_CMDS, the 'cmds' pointer is NULL but is dereferenced below.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 0f2bb84d2a68 ("[SCSI] megaraid: simplify internal command handling")
Signed-off-by: Danila Chernetsov <[email protected]>
---
drivers/scsi/megaraid.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
index bf491af9f0d6..16e2cf848c6e 100644
--- a/drivers/scsi/megaraid.c
+++ b/drivers/scsi/megaraid.c
@@ -1441,6 +1441,7 @@ mega_cmd_done(adapter_t *adapter, u8 completed[], int nstatus, int status)
*/
if (cmdid == CMDID_INT_CMDS) {
scb = &adapter->int_scb;
+ cmd = scb->cmd;

list_del_init(&scb->list);
scb->state = SCB_FREE;
--
2.25.1

2023-04-03 02:16:44

by Martin K. Petersen

Subject: Re: [PATCH] megaraid: fix mega_cmd_done CMDID_INT_CMDS

On Fri, 17 Mar 2023 17:51:09 +0000, Danila Chernetsov wrote:

> When cmdid == CMDID_INT_CMDS, the 'cmds' pointer is NULL but is dereferenced below.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
>

Applied to 6.4/scsi-queue, thanks!

[1/1] megaraid: fix mega_cmd_done CMDID_INT_CMDS
https://git.kernel.org/mkp/scsi/c/75cb113cd43f

--
Martin K. Petersen Oracle Linux Engineering