2023-03-19 04:41:48

by Lizhe

Subject: [PATCH v1] w1/w1.c : Remove driver match function

If there is no driver match function, the driver core assumes that each
candidate pair (driver, device) matches, see driver_match_device().

Drop the bus's match function that always returned 1 and so
implements the same behaviour as when there is no match function

Signed-off-by: Lizhe <[email protected]>
---
drivers/w1/w1.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index 9d199fed9628..e7e42f9dabf4 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -58,11 +58,6 @@ MODULE_PARM_DESC(slave_ttl,
DEFINE_MUTEX(w1_mlock);
LIST_HEAD(w1_masters);

-static int w1_master_match(struct device *dev, struct device_driver *drv)
-{
- return 1;
-}
-
static int w1_master_probe(struct device *dev)
{
return -ENODEV;
@@ -174,7 +169,6 @@ static int w1_uevent(const struct device *dev, struct kobj_uevent_env *env);

static struct bus_type w1_bus_type = {
.name = "w1",
- .match = w1_master_match,
.uevent = w1_uevent,
};

--
2.34.1

2023-05-08 09:25:59

by Krzysztof Kozlowski

Subject: Re: [PATCH v1] w1/w1.c : Remove driver match function

On Sun, 19 Mar 2023 12:41:07 +0800, Lizhe wrote:
> If there is no driver match function, the driver core assumes that each
> candidate pair (driver, device) matches, see driver_match_device().
>
> Drop the bus's match function that always returned 1 and so
> implements the same behaviour as when there is no match function
>
>
> [...]

Applied, thanks!

[1/1] w1/w1.c : Remove driver match function
https://git.kernel.org/krzk/linux-w1/c/388f22fe5d91d707352b4b743368b30e21d9d9bf

Best regards,
--
Krzysztof Kozlowski <[email protected]>