2023-03-19 14:37:41

by Tom Rix

Subject: [PATCH] gpio: pxa: remove unused gpio_is_pxa_type function

clang with W=1 reports
drivers/gpio/gpio-pxa.c:174:19: error: unused function
'gpio_is_pxa_type' [-Werror,-Wunused-function]
static inline int gpio_is_pxa_type(int type)
^
This function is not used, so remove it.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/gpio/gpio-pxa.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index 1198ab0305d0..a1630ed4b741 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -171,11 +171,6 @@ static inline struct pxa_gpio_bank *gpio_to_pxabank(struct gpio_chip *c,
return chip_to_pxachip(c)->banks + gpio / 32;
}

-static inline int gpio_is_pxa_type(int type)
-{
- return (type & MMP_GPIO) == 0;
-}
-
static inline int gpio_is_mmp_type(int type)
{
return (type & MMP_GPIO) != 0;
--
2.27.0

2023-03-19 21:18:06

by Linus Walleij

Subject: Re: [PATCH] gpio: pxa: remove unused gpio_is_pxa_type function

On Sun, Mar 19, 2023 at 3:36 PM Tom Rix <[email protected]> wrote:

> clang with W=1 reports
> drivers/gpio/gpio-pxa.c:174:19: error: unused function
> 'gpio_is_pxa_type' [-Werror,-Wunused-function]
> static inline int gpio_is_pxa_type(int type)
> ^
> This function is not used, so remove it.
>
> Signed-off-by: Tom Rix <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2023-03-22 16:29:30

by Bartosz Golaszewski

Subject: Re: [PATCH] gpio: pxa: remove unused gpio_is_pxa_type function

On Sun, Mar 19, 2023 at 3:36 PM Tom Rix <[email protected]> wrote:
>
> clang with W=1 reports
> drivers/gpio/gpio-pxa.c:174:19: error: unused function
> 'gpio_is_pxa_type' [-Werror,-Wunused-function]
> static inline int gpio_is_pxa_type(int type)
> ^
> This function is not used, so remove it.
>
> Signed-off-by: Tom Rix <[email protected]>
> ---
> drivers/gpio/gpio-pxa.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
> index 1198ab0305d0..a1630ed4b741 100644
> --- a/drivers/gpio/gpio-pxa.c
> +++ b/drivers/gpio/gpio-pxa.c
> @@ -171,11 +171,6 @@ static inline struct pxa_gpio_bank *gpio_to_pxabank(struct gpio_chip *c,
> return chip_to_pxachip(c)->banks + gpio / 32;
> }
>
> -static inline int gpio_is_pxa_type(int type)
> -{
> - return (type & MMP_GPIO) == 0;
> -}
> -
> static inline int gpio_is_mmp_type(int type)
> {
> return (type & MMP_GPIO) != 0;
> --
> 2.27.0
>

Applied, thanks!

Bart