2023-03-20 23:13:07

by Tom Rix

Subject: [PATCH] dmaengine: ti: edma: remove unused edma_and function

clang with W=1 reports
drivers/dma/ti/edma.c:321:20: error: unused function
'edma_and' [-Werror,-Wunused-function]
static inline void edma_and(struct edma_cc *ecc, int offset, unsigned and)
^
This function is not used, so remove it.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/dma/ti/edma.c | 8 --------
1 file changed, 8 deletions(-)

diff --git a/drivers/dma/ti/edma.c b/drivers/dma/ti/edma.c
index fa06d7e6d8e3..9ea91c640c32 100644
--- a/drivers/dma/ti/edma.c
+++ b/drivers/dma/ti/edma.c
@@ -318,14 +318,6 @@ static inline void edma_modify(struct edma_cc *ecc, int offset, unsigned and,
edma_write(ecc, offset, val);
}

-static inline void edma_and(struct edma_cc *ecc, int offset, unsigned and)
-{
- unsigned val = edma_read(ecc, offset);
-
- val &= and;
- edma_write(ecc, offset, val);
-}
-
static inline void edma_or(struct edma_cc *ecc, int offset, unsigned or)
{
unsigned val = edma_read(ecc, offset);
--
2.27.0

2023-03-31 12:36:43

by Vinod Koul

Subject: Re: [PATCH] dmaengine: ti: edma: remove unused edma_and function

On 20-03-23, 19:12, Tom Rix wrote:
> clang with W=1 reports
> drivers/dma/ti/edma.c:321:20: error: unused function
> 'edma_and' [-Werror,-Wunused-function]
> static inline void edma_and(struct edma_cc *ecc, int offset, unsigned and)
> ^
> This function is not used, so remove it.

Applied, thanks

--
~Vinod