2023-03-20 23:24:19

by Tom Rix

[permalink] [raw]
Subject: [PATCH] net: atheros: atl1c: remove unused atl1c_irq_reset function

clang with W=1 reports
drivers/net/ethernet/atheros/atl1c/atl1c_main.c:214:20: error:
unused function 'atl1c_irq_reset' [-Werror,-Wunused-function]
static inline void atl1c_irq_reset(struct atl1c_adapter *adapter)
^
This function is not used, so remove it.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 10 ----------
1 file changed, 10 deletions(-)

diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
index 40c781695d58..4a288799633f 100644
--- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
+++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
@@ -207,16 +207,6 @@ static inline void atl1c_irq_disable(struct atl1c_adapter *adapter)
synchronize_irq(adapter->pdev->irq);
}

-/**
- * atl1c_irq_reset - reset interrupt confiure on the NIC
- * @adapter: board private structure
- */
-static inline void atl1c_irq_reset(struct atl1c_adapter *adapter)
-{
- atomic_set(&adapter->irq_sem, 1);
- atl1c_irq_enable(adapter);
-}
-
/*
* atl1c_wait_until_idle - wait up to AT_HW_MAX_IDLE_DELAY reads
* of the idle status register until the device is actually idle
--
2.27.0



2023-03-21 04:51:17

by Pavan Chebbi

[permalink] [raw]
Subject: Re: [PATCH] net: atheros: atl1c: remove unused atl1c_irq_reset function

On Tue, Mar 21, 2023 at 4:54 AM Tom Rix <[email protected]> wrote:
>
> clang with W=1 reports
> drivers/net/ethernet/atheros/atl1c/atl1c_main.c:214:20: error:
> unused function 'atl1c_irq_reset' [-Werror,-Wunused-function]
> static inline void atl1c_irq_reset(struct atl1c_adapter *adapter)
> ^
> This function is not used, so remove it.
>
> Signed-off-by: Tom Rix <[email protected]>
> ---
> drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 10 ----------
> 1 file changed, 10 deletions(-)

Looks good to me.
Reviewed-by: Pavan Chebbi <[email protected]>

>
> diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> index 40c781695d58..4a288799633f 100644
> --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> @@ -207,16 +207,6 @@ static inline void atl1c_irq_disable(struct atl1c_adapter *adapter)
> synchronize_irq(adapter->pdev->irq);
> }
>
> -/**
> - * atl1c_irq_reset - reset interrupt confiure on the NIC
> - * @adapter: board private structure
> - */
> -static inline void atl1c_irq_reset(struct atl1c_adapter *adapter)
> -{
> - atomic_set(&adapter->irq_sem, 1);
> - atl1c_irq_enable(adapter);
> -}
> -
> /*
> * atl1c_wait_until_idle - wait up to AT_HW_MAX_IDLE_DELAY reads
> * of the idle status register until the device is actually idle
> --
> 2.27.0
>

Attachments:
smime.p7s (4.11 kB)
S/MIME Cryptographic Signature

2023-03-22 05:43:32

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH] net: atheros: atl1c: remove unused atl1c_irq_reset function

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:

On Mon, 20 Mar 2023 19:23:17 -0400 you wrote:
> clang with W=1 reports
> drivers/net/ethernet/atheros/atl1c/atl1c_main.c:214:20: error:
> unused function 'atl1c_irq_reset' [-Werror,-Wunused-function]
> static inline void atl1c_irq_reset(struct atl1c_adapter *adapter)
> ^
> This function is not used, so remove it.
>
> [...]

Here is the summary with links:
- net: atheros: atl1c: remove unused atl1c_irq_reset function
https://git.kernel.org/netdev/net-next/c/f6f4e739b164

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html