2023-03-21 04:26:55

by Lukas Bulwahn

[permalink] [raw]
Subject: [PATCH] clk: mediatek: Remove unused configs with COMMON_CLK_MT6765 prefix

Commit 1aca9939bf72 ("clk: mediatek: Add MT6765 clock support") adds
fourteen configs with COMMON_CLK_MT6765 prefix, but only uses seven of them
to configure inclusion of drivers.

Remove the seven unused COMMON_CLK_MT6765 configs.

Signed-off-by: Lukas Bulwahn <[email protected]>
---
drivers/clk/mediatek/Kconfig | 42 ------------------------------------
1 file changed, 42 deletions(-)

diff --git a/drivers/clk/mediatek/Kconfig b/drivers/clk/mediatek/Kconfig
index 2d14855dd37e..ec87762bfb18 100644
--- a/drivers/clk/mediatek/Kconfig
+++ b/drivers/clk/mediatek/Kconfig
@@ -144,12 +144,6 @@ config COMMON_CLK_MT6765_CAMSYS
help
This driver supports MediaTek MT6765 camsys clocks.

-config COMMON_CLK_MT6765_GCESYS
- bool "Clock driver for MediaTek MT6765 gcesys"
- depends on COMMON_CLK_MT6765
- help
- This driver supports MediaTek MT6765 gcesys clocks.
-
config COMMON_CLK_MT6765_MMSYS
bool "Clock driver for MediaTek MT6765 mmsys"
depends on COMMON_CLK_MT6765
@@ -168,48 +162,12 @@ config COMMON_CLK_MT6765_VCODECSYS
help
This driver supports MediaTek MT6765 vcodecsys clocks.

-config COMMON_CLK_MT6765_MFGSYS
- bool "Clock driver for MediaTek MT6765 mfgsys"
- depends on COMMON_CLK_MT6765
- help
- This driver supports MediaTek MT6765 mfgsys clocks.
-
config COMMON_CLK_MT6765_MIPI0ASYS
bool "Clock driver for MediaTek MT6765 mipi0asys"
depends on COMMON_CLK_MT6765
help
This driver supports MediaTek MT6765 mipi0asys clocks.

-config COMMON_CLK_MT6765_MIPI0BSYS
- bool "Clock driver for MediaTek MT6765 mipi0bsys"
- depends on COMMON_CLK_MT6765
- help
- This driver supports MediaTek MT6765 mipi0bsys clocks.
-
-config COMMON_CLK_MT6765_MIPI1ASYS
- bool "Clock driver for MediaTek MT6765 mipi1asys"
- depends on COMMON_CLK_MT6765
- help
- This driver supports MediaTek MT6765 mipi1asys clocks.
-
-config COMMON_CLK_MT6765_MIPI1BSYS
- bool "Clock driver for MediaTek MT6765 mipi1bsys"
- depends on COMMON_CLK_MT6765
- help
- This driver supports MediaTek MT6765 mipi1bsys clocks.
-
-config COMMON_CLK_MT6765_MIPI2ASYS
- bool "Clock driver for MediaTek MT6765 mipi2asys"
- depends on COMMON_CLK_MT6765
- help
- This driver supports MediaTek MT6765 mipi2asys clocks.
-
-config COMMON_CLK_MT6765_MIPI2BSYS
- bool "Clock driver for MediaTek MT6765 mipi2bsys"
- depends on COMMON_CLK_MT6765
- help
- This driver supports MediaTek MT6765 mipi2bsys clocks.
-
config COMMON_CLK_MT6779
tristate "Clock driver for MediaTek MT6779"
depends on (ARCH_MEDIATEK && ARM64) || COMPILE_TEST
--
2.17.1



Subject: Re: [PATCH] clk: mediatek: Remove unused configs with COMMON_CLK_MT6765 prefix

Il 21/03/23 05:26, Lukas Bulwahn ha scritto:
> Commit 1aca9939bf72 ("clk: mediatek: Add MT6765 clock support") adds
> fourteen configs with COMMON_CLK_MT6765 prefix, but only uses seven of them
> to configure inclusion of drivers.
>
> Remove the seven unused COMMON_CLK_MT6765 configs.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>

Please add the required Fixes tag (you even reference the commit to fix already!),
then you'll get my R-b at v2 :-)

Regards,
Angelo



2023-03-28 15:47:25

by Matthias Brugger

[permalink] [raw]
Subject: Re: [PATCH] clk: mediatek: Remove unused configs with COMMON_CLK_MT6765 prefix



On 3/21/23 09:55, AngeloGioacchino Del Regno wrote:
> Il 21/03/23 05:26, Lukas Bulwahn ha scritto:
>> Commit 1aca9939bf72 ("clk: mediatek: Add MT6765 clock support") adds
>> fourteen configs with COMMON_CLK_MT6765 prefix, but only uses seven of
>> them
>> to configure inclusion of drivers.
>>
>> Remove the seven unused COMMON_CLK_MT6765 configs.
>>
>> Signed-off-by: Lukas Bulwahn <[email protected]>
>
> Please add the required Fixes tag (you even reference the commit to fix
> already!),
> then you'll get my R-b at v2 :-)
>

What bug get's fixed by this? This is just a code clean-up, no bug get's
fixed with it. So there is no reason to be backported to any stable or
distribution kernels.

Regards,
Matthias