2023-03-21 11:49:05

by Tom Rix

Subject: [PATCH] mtd: rawnand: remove unused is_imx51_nfc and imx53_nfc functions

clang with W=1 reports
drivers/mtd/nand/raw/mxc_nand.c:1602:19: error: unused function
'is_imx51_nfc' [-Werror,-Wunused-function]
static inline int is_imx51_nfc(struct mxc_nand_host *host)
^
drivers/mtd/nand/raw/mxc_nand.c:1607:19: error: unused function
'is_imx53_nfc' [-Werror,-Wunused-function]
static inline int is_imx53_nfc(struct mxc_nand_host *host)
^
These functions are not used, so remove them.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/mtd/nand/raw/mxc_nand.c | 10 ----------
1 file changed, 10 deletions(-)

diff --git a/drivers/mtd/nand/raw/mxc_nand.c b/drivers/mtd/nand/raw/mxc_nand.c
index f6c96341b896..f61ffcbe57c8 100644
--- a/drivers/mtd/nand/raw/mxc_nand.c
+++ b/drivers/mtd/nand/raw/mxc_nand.c
@@ -1599,16 +1599,6 @@ static inline int is_imx25_nfc(struct mxc_nand_host *host)
return host->devtype_data == &imx25_nand_devtype_data;
}

-static inline int is_imx51_nfc(struct mxc_nand_host *host)
-{
- return host->devtype_data == &imx51_nand_devtype_data;
-}
-
-static inline int is_imx53_nfc(struct mxc_nand_host *host)
-{
- return host->devtype_data == &imx53_nand_devtype_data;
-}
-
static const struct of_device_id mxcnd_dt_ids[] = {
{ .compatible = "fsl,imx21-nand", .data = &imx21_nand_devtype_data, },
{ .compatible = "fsl,imx27-nand", .data = &imx27_nand_devtype_data, },
--
2.27.0

2023-03-22 16:10:29

by Miquel Raynal

Subject: Re: [PATCH] mtd: rawnand: remove unused is_imx51_nfc and imx53_nfc functions

On Tue, 2023-03-21 at 11:46:38 UTC, Tom Rix wrote:
> clang with W=1 reports
> drivers/mtd/nand/raw/mxc_nand.c:1602:19: error: unused function
> 'is_imx51_nfc' [-Werror,-Wunused-function]
> static inline int is_imx51_nfc(struct mxc_nand_host *host)
> ^
> drivers/mtd/nand/raw/mxc_nand.c:1607:19: error: unused function
> 'is_imx53_nfc' [-Werror,-Wunused-function]
> static inline int is_imx53_nfc(struct mxc_nand_host *host)
> ^
> These functions are not used, so remove them.
>
> Signed-off-by: Tom Rix <[email protected]>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel