2023-03-21 11:48:57

by Max Chou

Subject: [PATCH 1/1] Bluetooth: btrtl: check for NULL in btrtl_set_quirks()

From: Max Chou <[email protected]>

The btrtl_set_quirks() has accessed btrtl_dev->ic_info->lmp_subver since
b8e482d02513. However, if installing a Realtek Bluetooth controller
without the driver supported, it will hit the NULL point accessed.

Add a check for NULL to avoid the Kernel Oops.

Signed-off-by: Max Chou <[email protected]>
---
drivers/bluetooth/btrtl.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index 8fa7733812ad..0f256a8abef4 100644
--- a/drivers/bluetooth/btrtl.c
+++ b/drivers/bluetooth/btrtl.c
@@ -905,6 +905,9 @@ void btrtl_set_quirks(struct hci_dev *hdev, struct btrtl_device_info *btrtl_dev)
break;
}

+ if (!btrtl_dev->ic_info)
+ return;
+
switch (btrtl_dev->ic_info->lmp_subver) {
case RTL_ROM_LMP_8703B:
/* 8723CS reports two pages for local ext features,
--
2.34.1

2023-03-29 20:00:35

by patchwork-bot+bluetooth

Subject: Re: [PATCH 1/1] Bluetooth: btrtl: check for NULL in btrtl_set_quirks()

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Tue, 21 Mar 2023 19:48:26 +0800 you wrote:
> From: Max Chou <[email protected]>
>
> The btrtl_set_quirks() has accessed btrtl_dev->ic_info->lmp_subver since
> b8e482d02513. However, if installing a Realtek Bluetooth controller
> without the driver supported, it will hit the NULL point accessed.
>
> Add a check for NULL to avoid the Kernel Oops.
>
> [...]

Here is the summary with links:
- [1/1] Bluetooth: btrtl: check for NULL in btrtl_set_quirks()
https://git.kernel.org/bluetooth/bluetooth-next/c/dfa0a31c0cee

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html