2023-03-21 18:50:02

by Tom Rix

Subject: [PATCH] liquidio: remove unused IQ_INSTR_MODE_64B function

clang with W=1 reports
drivers/net/ethernet/cavium/liquidio/request_manager.c:43:19: error:
unused function 'IQ_INSTR_MODE_64B' [-Werror,-Wunused-function]
static inline int IQ_INSTR_MODE_64B(struct octeon_device *oct, int iq_no)
^
This function and its macro wrapper are not used, so remove them.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/net/ethernet/cavium/liquidio/request_manager.c | 9 ---------
1 file changed, 9 deletions(-)

diff --git a/drivers/net/ethernet/cavium/liquidio/request_manager.c b/drivers/net/ethernet/cavium/liquidio/request_manager.c
index 8e59c2825533..32f854c0cd79 100644
--- a/drivers/net/ethernet/cavium/liquidio/request_manager.c
+++ b/drivers/net/ethernet/cavium/liquidio/request_manager.c
@@ -40,15 +40,6 @@ static void __check_db_timeout(struct octeon_device *oct, u64 iq_no);

static void (*reqtype_free_fn[MAX_OCTEON_DEVICES][REQTYPE_LAST + 1]) (void *);

-static inline int IQ_INSTR_MODE_64B(struct octeon_device *oct, int iq_no)
-{
- struct octeon_instr_queue *iq =
- (struct octeon_instr_queue *)oct->instr_queue[iq_no];
- return iq->iqcmd_64B;
-}
-
-#define IQ_INSTR_MODE_32B(oct, iq_no) (!IQ_INSTR_MODE_64B(oct, iq_no))
-
/* Define this to return the request status comaptible to old code */
/*#define OCTEON_USE_OLD_REQ_STATUS*/

--
2.27.0

2023-03-22 16:49:51

by Simon Horman

Subject: Re: [PATCH] liquidio: remove unused IQ_INSTR_MODE_64B function

On Tue, Mar 21, 2023 at 02:48:11PM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/net/ethernet/cavium/liquidio/request_manager.c:43:19: error:
> unused function 'IQ_INSTR_MODE_64B' [-Werror,-Wunused-function]
> static inline int IQ_INSTR_MODE_64B(struct octeon_device *oct, int iq_no)
> ^
> This function and its macro wrapper are not used, so remove them.
>
> Signed-off-by: Tom Rix <[email protected]>

Reviewed-by: Simon Horman <[email protected]>

2023-03-23 05:11:56

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] liquidio: remove unused IQ_INSTR_MODE_64B function

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:

On Tue, 21 Mar 2023 14:48:11 -0400 you wrote:
> clang with W=1 reports
> drivers/net/ethernet/cavium/liquidio/request_manager.c:43:19: error:
> unused function 'IQ_INSTR_MODE_64B' [-Werror,-Wunused-function]
> static inline int IQ_INSTR_MODE_64B(struct octeon_device *oct, int iq_no)
> ^
> This function and its macro wrapper are not used, so remove them.
>
> [...]

Here is the summary with links:
- liquidio: remove unused IQ_INSTR_MODE_64B function
https://git.kernel.org/netdev/net-next/c/603c3345589d

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html