2023-03-22 13:10:44

by Tom Rix

[permalink] [raw]
Subject: [PATCH] mfd: omap-usb-tll: remove unused usbtll_readb function

clang with W=1 reports
drivers/mfd/omap-usb-tll.c:128:18: error: unused function
'usbtll_readb' [-Werror,-Wunused-function]
static inline u8 usbtll_readb(void __iomem *base, u32 reg)
^
This function is not used so remove it.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/mfd/omap-usb-tll.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
index 8ca4067da6cd..69cbc2097911 100644
--- a/drivers/mfd/omap-usb-tll.c
+++ b/drivers/mfd/omap-usb-tll.c
@@ -125,11 +125,6 @@ static inline void usbtll_writeb(void __iomem *base, u32 reg, u8 val)
writeb_relaxed(val, base + reg);
}

-static inline u8 usbtll_readb(void __iomem *base, u32 reg)
-{
- return readb_relaxed(base + reg);
-}
-
/*-------------------------------------------------------------------------*/

static bool is_ohci_port(enum usbhs_omap_port_mode pmode)
--
2.27.0


2023-03-30 12:39:06

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH] mfd: omap-usb-tll: remove unused usbtll_readb function

On Wed, 22 Mar 2023, Tom Rix wrote:

> clang with W=1 reports
> drivers/mfd/omap-usb-tll.c:128:18: error: unused function
> 'usbtll_readb' [-Werror,-Wunused-function]
> static inline u8 usbtll_readb(void __iomem *base, u32 reg)
> ^
> This function is not used so remove it.
>
> Signed-off-by: Tom Rix <[email protected]>
> ---
> drivers/mfd/omap-usb-tll.c | 5 -----
> 1 file changed, 5 deletions(-)

Applied, thanks

--
Lee Jones [李琼斯]