2023-03-17 15:43:14

by ChiYuan Huang

Subject: [PATCH] leds: rgb: mt6370: Fix implicit declaration for FIELD_GET

From: ChiYuan Huang <[email protected]>

0-DAY CI Kernel Test Service reported the implicit declaration error below:

drivers/leds/rgb/leds-mt6370-rgb.c: In function'mt6370_check_vendor_info':
>> drivers/leds/rgb/leds-mt6370-rgb.c:889:15: error: implicit declaration
of function 'FIELD_GET' [-Werror=implicit-function-declaration]
889 | vid = FIELD_GET(MT6370_VENDOR_ID_MASK, devinfo);
|

Add the missing header 'bitfield.h' to fix it.

Reported-by: kernel test robot <[email protected]>
Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Fixes: 55a8a5c16eb3 ("leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support")
Signed-off-by: ChiYuan Huang <[email protected]>
---
drivers/leds/rgb/leds-mt6370-rgb.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/leds/rgb/leds-mt6370-rgb.c b/drivers/leds/rgb/leds-mt6370-rgb.c
index 9c1e6d5..bb62431 100644
--- a/drivers/leds/rgb/leds-mt6370-rgb.c
+++ b/drivers/leds/rgb/leds-mt6370-rgb.c
@@ -7,6 +7,7 @@
* Alice Chen <[email protected]>
*/

+#include <linux/bitfield.h>
#include <linux/bitops.h>
#include <linux/kernel.h>
#include <linux/leds.h>
--
2.7.4

2023-03-22 15:41:05

by Lee Jones

Subject: Re: [PATCH] leds: rgb: mt6370: Fix implicit declaration for FIELD_GET

On Fri, 17 Mar 2023, [email protected] wrote:

> From: ChiYuan Huang <[email protected]>
>
> 0-DAY CI Kernel Test Service reported the implicit declaration error below:
>
> drivers/leds/rgb/leds-mt6370-rgb.c: In function'mt6370_check_vendor_info':
> >> drivers/leds/rgb/leds-mt6370-rgb.c:889:15: error: implicit declaration
> of function 'FIELD_GET' [-Werror=implicit-function-declaration]
> 889 | vid = FIELD_GET(MT6370_VENDOR_ID_MASK, devinfo);
> |
>
> Add the missing header 'bitfield.h' to fix it.
>
> Reported-by: kernel test robot <[email protected]>
> Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Fixes: 55a8a5c16eb3 ("leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support")
> Signed-off-by: ChiYuan Huang <[email protected]>
> ---
> drivers/leds/rgb/leds-mt6370-rgb.c | 1 +
> 1 file changed, 1 insertion(+)

Applied, thanks

--
Lee Jones [李琼斯]