2023-03-22 17:38:09

by Krzysztof Kozlowski

Subject: [PATCH v3 1/2] dt-bindings: mailbox: qcom,apcs-kpss-global: correct SDX55 clocks

SDX55 and SDX65 DTS takes clocks in a bit different order. Adjust
bindings to the DTS.

Fixes: 0d17014e9189 ("dt-bindings: mailbox: Add binding for SDX55 APCS")
Signed-off-by: Krzysztof Kozlowski <[email protected]>
Acked-by: Rob Herring <[email protected]>
Acked-by: Manivannan Sadhasivam <[email protected]>

---

Changes since v1:
1. Add Fixes tag
2. Add Acks
3. Split from other patchset, so it can be applied independently
---
.../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
index d888ead09282..2992227631c4 100644
--- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
+++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
@@ -97,14 +97,14 @@ allOf:
properties:
clocks:
items:
+ - description: reference clock
- description: primary pll parent of the clock driver
- description: auxiliary parent
- - description: reference clock
clock-names:
items:
+ - const: ref
- const: pll
- const: aux
- - const: ref
- if:
properties:
compatible:
--
2.34.1

2023-03-22 17:38:25

by Krzysztof Kozlowski

Subject: [PATCH v3 2/2] dt-bindings: mailbox: qcom,apcs-kpss-global: fix SDX55 'if' match

The qcom,sdx55-apcs-gcc is followed by another compatible (syscon), thus
the 'if' clause must match by contains.

Fixes: 0d17014e9189 ("dt-bindings: mailbox: Add binding for SDX55 APCS")
Signed-off-by: Krzysztof Kozlowski <[email protected]>
Acked-by: Rob Herring <[email protected]>
Acked-by: Manivannan Sadhasivam <[email protected]>

---

Changes since v1:
1. Add Acks
2. Split from other patchset, so it can be applied independently
---
.../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
index 2992227631c4..4d2f408a5efb 100644
--- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
+++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
@@ -91,8 +91,9 @@ allOf:
- if:
properties:
compatible:
- enum:
- - qcom,sdx55-apcs-gcc
+ contains:
+ enum:
+ - qcom,sdx55-apcs-gcc
then:
properties:
clocks:
--
2.34.1

2023-03-24 18:34:11

by Bjorn Andersson

Subject: Re: (subset) [PATCH v3 1/2] dt-bindings: mailbox: qcom,apcs-kpss-global: correct SDX55 clocks

On Wed, 22 Mar 2023 18:35:58 +0100, Krzysztof Kozlowski wrote:
> SDX55 and SDX65 DTS takes clocks in a bit different order. Adjust
> bindings to the DTS.
>
>

Applied, thanks!

[1/2] dt-bindings: mailbox: qcom,apcs-kpss-global: correct SDX55 clocks
commit: 8504fa9baf8bdc5f333f24077b54df1d16173d99
[2/2] dt-bindings: mailbox: qcom,apcs-kpss-global: fix SDX55 'if' match
commit: 22ead09ba40745e50970565af1996c2c1cc4e909

Best regards,
--
Bjorn Andersson <[email protected]>