2023-03-22 17:42:13

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v3 00/11] mailbox/arm64/ qcom: rework compatibles for fallback

Hi,

Changes since v2
================
1. Split fixes to separate patchset which is now dependency:
https://lore.kernel.org/linux-arm-msm/[email protected]/T/#t
2. Add Ack
3. No other changes, as discussion with Dmitry did not reach conclusion on incompatibility.

Changes since v1
================
1. Rebase
2. Make msm8994 fallback for several variants, not msm8953, because the latter
actually might take some clocks.
3. Two new patches for SDX55.
4. Minor corrections in bindings style.
v1: https://lore.kernel.org/all/[email protected]/

Description
===========

If entire approach is accepted (and correct), there are no dependencies and
patches can be picked independently. Although the best in the same cycle, so
there will be no new `dtbs_check` warnings.

Best regards,
Krzysztof

Krzysztof Kozlowski (11):
dt-bindings: mailbox: qcom,apcs-kpss-global: use fallbacks
mailbox: qcom-apcs-ipc: do not grow the of_device_id
arm64: dts: qcom: ipq8074: add compatible fallback to mailbox
arm64: dts: qcom: msm8976: add compatible fallback to mailbox
arm64: dts: qcom: msm8998: add compatible fallback to mailbox
arm64: dts: qcom: sdm630: add compatible fallback to mailbox
arm64: dts: qcom: sm6115: add compatible fallback to mailbox
arm64: dts: qcom: sm6125: add compatible fallback to mailbox
arm64: dts: qcom: qcs404: add compatible fallback to mailbox
arm64: dts: qcom: sc7180: add compatible fallback to mailbox
arm64: dts: qcom: sm8150: add compatible fallback to mailbox

.../mailbox/qcom,apcs-kpss-global.yaml | 58 ++++++++++---------
arch/arm64/boot/dts/qcom/ipq8074.dtsi | 3 +-
arch/arm64/boot/dts/qcom/msm8976.dtsi | 3 +-
arch/arm64/boot/dts/qcom/msm8998.dtsi | 3 +-
arch/arm64/boot/dts/qcom/qcs404.dtsi | 3 +-
arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 +-
arch/arm64/boot/dts/qcom/sdm630.dtsi | 3 +-
arch/arm64/boot/dts/qcom/sm6115.dtsi | 3 +-
arch/arm64/boot/dts/qcom/sm6125.dtsi | 3 +-
arch/arm64/boot/dts/qcom/sm8150.dtsi | 3 +-
drivers/mailbox/qcom-apcs-ipc-mailbox.c | 11 ++--
11 files changed, 55 insertions(+), 41 deletions(-)

--
2.34.1


2023-03-22 17:42:19

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v3 01/11] dt-bindings: mailbox: qcom,apcs-kpss-global: use fallbacks

Rework the compatibles and group devices which have similar interface
(same from Linux driver point of view) as compatible. This allows
smaller of_device_id table in the Linux driver and smaller
allOf:if:then: constraints.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
Acked-by: Rob Herring <[email protected]>

---

Depends on:
https://lore.kernel.org/linux-arm-msm/[email protected]/T/#t
---
.../mailbox/qcom,apcs-kpss-global.yaml | 58 ++++++++++---------
1 file changed, 31 insertions(+), 27 deletions(-)

diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
index 4d2f408a5efb..792778924eb3 100644
--- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
+++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
@@ -19,32 +19,46 @@ properties:
- items:
- enum:
- qcom,ipq5332-apcs-apps-global
+ - qcom,ipq8074-apcs-apps-global
- const: qcom,ipq6018-apcs-apps-global
- items:
- enum:
- - qcom,ipq6018-apcs-apps-global
- - qcom,ipq8074-apcs-apps-global
- - qcom,msm8996-apcs-hmss-global
+ - qcom,msm8939-apcs-kpss-global
+ - qcom,qcs404-apcs-apps-global
+ - const: qcom,msm8916-apcs-kpss-global
+ - const: syscon
+ - items:
+ - enum:
+ - qcom,msm8976-apcs-kpss-global
+ - const: qcom,msm8994-apcs-kpss-global
+ - const: syscon
+ - items:
+ - enum:
- qcom,msm8998-apcs-hmss-global
- qcom,qcm2290-apcs-hmss-global
- - qcom,sc7180-apss-shared
- - qcom,sc8180x-apss-shared
- qcom,sdm660-apcs-hmss-global
- - qcom,sdm845-apss-shared
- qcom,sm4250-apcs-hmss-global
- - qcom,sm6125-apcs-hmss-global
- qcom,sm6115-apcs-hmss-global
+ - qcom,sm6125-apcs-hmss-global
+ - const: qcom,msm8994-apcs-kpss-global
+ - items:
+ - enum:
+ - qcom,sc7180-apss-shared
+ - qcom,sc8180x-apss-shared
- qcom,sm8150-apss-shared
+ - const: qcom,sdm845-apss-shared
- items:
- enum:
- qcom,msm8916-apcs-kpss-global
- - qcom,msm8939-apcs-kpss-global
- qcom,msm8953-apcs-kpss-global
- - qcom,msm8976-apcs-kpss-global
- qcom,msm8994-apcs-kpss-global
- - qcom,qcs404-apcs-apps-global
- qcom,sdx55-apcs-gcc
- const: syscon
+ - enum:
+ - qcom,ipq6018-apcs-apps-global
+ - qcom,msm8996-apcs-hmss-global
+ - qcom,sdm845-apss-shared
+
reg:
maxItems: 1

@@ -74,10 +88,9 @@ allOf:
- if:
properties:
compatible:
- enum:
- - qcom,msm8916-apcs-kpss-global
- - qcom,msm8939-apcs-kpss-global
- - qcom,qcs404-apcs-apps-global
+ contains:
+ enum:
+ - qcom,msm8916-apcs-kpss-global
then:
properties:
clocks:
@@ -88,6 +101,7 @@ allOf:
items:
- const: pll
- const: aux
+
- if:
properties:
compatible:
@@ -106,13 +120,13 @@ allOf:
- const: ref
- const: pll
- const: aux
+
- if:
properties:
compatible:
contains:
enum:
- qcom,ipq6018-apcs-apps-global
- - qcom,ipq8074-apcs-apps-global
then:
properties:
clocks:
@@ -129,19 +143,9 @@ allOf:
compatible:
enum:
- qcom,msm8953-apcs-kpss-global
- - qcom,msm8976-apcs-kpss-global
- qcom,msm8994-apcs-kpss-global
- qcom,msm8996-apcs-hmss-global
- - qcom,msm8998-apcs-hmss-global
- - qcom,qcm2290-apcs-hmss-global
- - qcom,sc7180-apss-shared
- - qcom,sc8180x-apss-shared
- - qcom,sdm660-apcs-hmss-global
- qcom,sdm845-apss-shared
- - qcom,sm4250-apcs-hmss-global
- - qcom,sm6115-apcs-hmss-global
- - qcom,sm6125-apcs-hmss-global
- - qcom,sm8150-apss-shared
then:
properties:
clocks: false
@@ -153,7 +157,6 @@ allOf:
contains:
enum:
- qcom,ipq6018-apcs-apps-global
- - qcom,ipq8074-apcs-apps-global
then:
properties:
'#clock-cells':
@@ -188,7 +191,8 @@ examples:
#define GCC_APSS_AHB_CLK_SRC 1
#define GCC_GPLL0_AO_OUT_MAIN 123
apcs: mailbox@b011000 {
- compatible = "qcom,qcs404-apcs-apps-global", "syscon";
+ compatible = "qcom,qcs404-apcs-apps-global",
+ "qcom,msm8916-apcs-kpss-global", "syscon";
reg = <0x0b011000 0x1000>;
#mbox-cells = <1>;
clocks = <&apcs_hfpll>, <&gcc GCC_GPLL0_AO_OUT_MAIN>;
--
2.34.1

2023-03-22 17:42:24

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v3 02/11] mailbox: qcom-apcs-ipc: do not grow the of_device_id

Re-organize the compatible devices and add a comment to avoid unneeded
of_device_id growth with every new SoC. These devices have quite a lot
of similarities and they can use only one compatible fallback for driver
binding.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/mailbox/qcom-apcs-ipc-mailbox.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
index 6bbf87c6d60b..f3ac0b035945 100644
--- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
+++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
@@ -143,17 +143,19 @@ static int qcom_apcs_ipc_remove(struct platform_device *pdev)
static const struct of_device_id qcom_apcs_ipc_of_match[] = {
{ .compatible = "qcom,ipq5332-apcs-apps-global", .data = &ipq6018_apcs_data },
{ .compatible = "qcom,ipq6018-apcs-apps-global", .data = &ipq6018_apcs_data },
- { .compatible = "qcom,ipq8074-apcs-apps-global", .data = &ipq6018_apcs_data },
{ .compatible = "qcom,msm8916-apcs-kpss-global", .data = &msm8916_apcs_data },
- { .compatible = "qcom,msm8939-apcs-kpss-global", .data = &msm8916_apcs_data },
{ .compatible = "qcom,msm8953-apcs-kpss-global", .data = &msm8994_apcs_data },
+ { .compatible = "qcom,msm8996-apcs-hmss-global", .data = &msm8996_apcs_data },
+ { .compatible = "qcom,sc7180-apss-shared", .data = &apps_shared_apcs_data },
+ { .compatible = "qcom,sdx55-apcs-gcc", .data = &sdx55_apcs_data },
+ /* Do not add any more entries using existing driver data */
+ { .compatible = "qcom,ipq8074-apcs-apps-global", .data = &ipq6018_apcs_data },
+ { .compatible = "qcom,msm8939-apcs-kpss-global", .data = &msm8916_apcs_data },
{ .compatible = "qcom,msm8976-apcs-kpss-global", .data = &msm8994_apcs_data },
{ .compatible = "qcom,msm8994-apcs-kpss-global", .data = &msm8994_apcs_data },
- { .compatible = "qcom,msm8996-apcs-hmss-global", .data = &msm8996_apcs_data },
{ .compatible = "qcom,msm8998-apcs-hmss-global", .data = &msm8994_apcs_data },
{ .compatible = "qcom,qcm2290-apcs-hmss-global", .data = &msm8994_apcs_data },
{ .compatible = "qcom,qcs404-apcs-apps-global", .data = &msm8916_apcs_data },
- { .compatible = "qcom,sc7180-apss-shared", .data = &apps_shared_apcs_data },
{ .compatible = "qcom,sc8180x-apss-shared", .data = &apps_shared_apcs_data },
{ .compatible = "qcom,sdm660-apcs-hmss-global", .data = &msm8994_apcs_data },
{ .compatible = "qcom,sdm845-apss-shared", .data = &apps_shared_apcs_data },
@@ -161,7 +163,6 @@ static const struct of_device_id qcom_apcs_ipc_of_match[] = {
{ .compatible = "qcom,sm6125-apcs-hmss-global", .data = &msm8994_apcs_data },
{ .compatible = "qcom,sm8150-apss-shared", .data = &apps_shared_apcs_data },
{ .compatible = "qcom,sm6115-apcs-hmss-global", .data = &msm8994_apcs_data },
- { .compatible = "qcom,sdx55-apcs-gcc", .data = &sdx55_apcs_data },
{}
};
MODULE_DEVICE_TABLE(of, qcom_apcs_ipc_of_match);
--
2.34.1

2023-03-22 17:42:34

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v3 03/11] arm64: dts: qcom: ipq8074: add compatible fallback to mailbox

IPQ8074 mailbox is compatible with IPQ6018.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/ipq8074.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
index 62d05d740646..3fa7a63db74e 100644
--- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
@@ -687,7 +687,8 @@ watchdog: watchdog@b017000 {
};

apcs_glb: mailbox@b111000 {
- compatible = "qcom,ipq8074-apcs-apps-global";
+ compatible = "qcom,ipq8074-apcs-apps-global",
+ "qcom,ipq6018-apcs-apps-global";
reg = <0x0b111000 0x1000>;
clocks = <&a53pll>, <&xo>;
clock-names = "pll", "xo";
--
2.34.1

2023-03-22 17:42:39

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v3 04/11] arm64: dts: qcom: msm8976: add compatible fallback to mailbox

MSM8976 mailbox is compatible with MSM8994.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/msm8976.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8976.dtsi b/arch/arm64/boot/dts/qcom/msm8976.dtsi
index 2d360d05aa5e..c726d879d6f1 100644
--- a/arch/arm64/boot/dts/qcom/msm8976.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8976.dtsi
@@ -1027,7 +1027,8 @@ intc: interrupt-controller@b000000 {
};

apcs: mailbox@b011000 {
- compatible = "qcom,msm8976-apcs-kpss-global", "syscon";
+ compatible = "qcom,msm8976-apcs-kpss-global",
+ "qcom,msm8994-apcs-kpss-global", "syscon";
reg = <0x0b011000 0x1000>;
#mbox-cells = <1>;
};
--
2.34.1

2023-03-22 17:42:39

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v3 06/11] arm64: dts: qcom: sdm630: add compatible fallback to mailbox

SDM630 mailbox is compatible with MSM8994.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sdm630.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi
index 5827cda270a0..e9169876da6f 100644
--- a/arch/arm64/boot/dts/qcom/sdm630.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi
@@ -2268,7 +2268,8 @@ gnoc: interconnect@17900000 {
};

apcs_glb: mailbox@17911000 {
- compatible = "qcom,sdm660-apcs-hmss-global";
+ compatible = "qcom,sdm660-apcs-hmss-global",
+ "qcom,msm8994-apcs-kpss-global";
reg = <0x17911000 0x1000>;

#mbox-cells = <1>;
--
2.34.1

2023-03-22 17:42:47

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v3 08/11] arm64: dts: qcom: sm6125: add compatible fallback to mailbox

SM6125 mailbox is compatible with MSM8994.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sm6125.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi
index 65033227718a..225c03f4e669 100644
--- a/arch/arm64/boot/dts/qcom/sm6125.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi
@@ -1211,7 +1211,8 @@ apps_smmu: iommu@c600000 {
};

apcs_glb: mailbox@f111000 {
- compatible = "qcom,sm6125-apcs-hmss-global";
+ compatible = "qcom,sm6125-apcs-hmss-global",
+ "qcom,msm8994-apcs-kpss-global";
reg = <0x0f111000 0x1000>;

#mbox-cells = <1>;
--
2.34.1

2023-03-22 17:42:48

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v3 05/11] arm64: dts: qcom: msm8998: add compatible fallback to mailbox

MSM8998 mailbox is compatible with MSM8994.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/msm8998.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index 8bc1c59127e5..65f9b56e1dda 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -2490,7 +2490,8 @@ glink-edge {
};

apcs_glb: mailbox@17911000 {
- compatible = "qcom,msm8998-apcs-hmss-global";
+ compatible = "qcom,msm8998-apcs-hmss-global",
+ "qcom,msm8994-apcs-kpss-global";
reg = <0x17911000 0x1000>;

#mbox-cells = <1>;
--
2.34.1

2023-03-22 17:42:54

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v3 07/11] arm64: dts: qcom: sm6115: add compatible fallback to mailbox

SM6115 mailbox is compatible with MSM8994.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sm6115.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
index fbd67d2c8d78..2feaf9c831fe 100644
--- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
@@ -2038,7 +2038,8 @@ watchdog@f017000 {
};

apcs_glb: mailbox@f111000 {
- compatible = "qcom,sm6115-apcs-hmss-global";
+ compatible = "qcom,sm6115-apcs-hmss-global",
+ "qcom,msm8994-apcs-kpss-global";
reg = <0x0 0x0f111000 0x0 0x1000>;

#mbox-cells = <1>;
--
2.34.1

2023-03-22 17:48:36

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v3 10/11] arm64: dts: qcom: sc7180: add compatible fallback to mailbox

SC7180 mailbox is compatible with SDM845.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index ebfa21e9ed8a..61d99c02a290 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -3407,7 +3407,8 @@ msi-controller@17a40000 {
};

apss_shared: mailbox@17c00000 {
- compatible = "qcom,sc7180-apss-shared";
+ compatible = "qcom,sc7180-apss-shared",
+ "qcom,sdm845-apss-shared";
reg = <0 0x17c00000 0 0x10000>;
#mbox-cells = <1>;
};
--
2.34.1

2023-03-22 17:51:14

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v3 11/11] arm64: dts: qcom: sm8150: add compatible fallback to mailbox

SC8150 mailbox is compatible with SDM845.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8150.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index 13e0ce828606..fa58ba82faf2 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -4097,7 +4097,8 @@ intc: interrupt-controller@17a00000 {
};

apss_shared: mailbox@17c00000 {
- compatible = "qcom,sm8150-apss-shared";
+ compatible = "qcom,sm8150-apss-shared",
+ "qcom,sdm845-apss-shared";
reg = <0x0 0x17c00000 0x0 0x1000>;
#mbox-cells = <1>;
};
--
2.34.1

2023-03-22 18:03:40

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v3 09/11] arm64: dts: qcom: qcs404: add compatible fallback to mailbox

QCS404 mailbox is compatible with MSM8916.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/qcs404.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
index bc2ed73afb74..e4fdc40be821 100644
--- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
@@ -1302,7 +1302,8 @@ intc: interrupt-controller@b000000 {
};

apcs_glb: mailbox@b011000 {
- compatible = "qcom,qcs404-apcs-apps-global", "syscon";
+ compatible = "qcom,qcs404-apcs-apps-global",
+ "qcom,msm8916-apcs-kpss-global", "syscon";
reg = <0x0b011000 0x1000>;
#mbox-cells = <1>;
clocks = <&apcs_hfpll>, <&gcc GCC_GPLL0_AO_OUT_MAIN>;
--
2.34.1

2023-04-07 18:54:34

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH v3 00/11] mailbox/arm64/ qcom: rework compatibles for fallback

On Wed, 22 Mar 2023 18:41:37 +0100, Krzysztof Kozlowski wrote:
> Changes since v2
> ================
> 1. Split fixes to separate patchset which is now dependency:
> https://lore.kernel.org/linux-arm-msm/[email protected]/T/#t
> 2. Add Ack
> 3. No other changes, as discussion with Dmitry did not reach conclusion on incompatibility.
>
> [...]

Applied, thanks!

[03/11] arm64: dts: qcom: ipq8074: add compatible fallback to mailbox
commit: d93bd4630ce163f3761aedc0b342b072bee6db6b
[04/11] arm64: dts: qcom: msm8976: add compatible fallback to mailbox
commit: 81cd4883b1a2d7c612df9f526598e6a841ab3881
[05/11] arm64: dts: qcom: msm8998: add compatible fallback to mailbox
commit: 112f33b369e5e38119910a3365537bcc5d3d4135
[06/11] arm64: dts: qcom: sdm630: add compatible fallback to mailbox
commit: 2d034324fdba6555fb642b127167ae5ba0e30158
[07/11] arm64: dts: qcom: sm6115: add compatible fallback to mailbox
commit: fb6198bb4980cd4a7a89affe6bef4e6e81e97316
[08/11] arm64: dts: qcom: sm6125: add compatible fallback to mailbox
commit: 61799f9d573fe31222b0224acbb545fae259366a
[09/11] arm64: dts: qcom: qcs404: add compatible fallback to mailbox
commit: 4c90ceae6ec093ee9a73a48c8dacaa6d1404770b
[10/11] arm64: dts: qcom: sc7180: add compatible fallback to mailbox
commit: c1393bdf181143b21cb1ad8dbad6f3840b171855
[11/11] arm64: dts: qcom: sm8150: add compatible fallback to mailbox
commit: 9b2e284a5dc2d23a7102ff87fac3aa9d6b88118e

Best regards,
--
Bjorn Andersson <[email protected]>

2023-08-05 13:59:45

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH v3 00/11] mailbox/arm64/ qcom: rework compatibles for fallback

On 22.03.2023 18:41, Krzysztof Kozlowski wrote:
> Hi,
>
> Changes since v2
> ================
> 1. Split fixes to separate patchset which is now dependency:
> https://lore.kernel.org/linux-arm-msm/[email protected]/T/#t
> 2. Add Ack
> 3. No other changes, as discussion with Dmitry did not reach conclusion on incompatibility.
>
> Changes since v1
> ================
> 1. Rebase
> 2. Make msm8994 fallback for several variants, not msm8953, because the latter
> actually might take some clocks.
> 3. Two new patches for SDX55.
> 4. Minor corrections in bindings style.
> v1: https://lore.kernel.org/all/[email protected]/
>
> Description
> ===========
>
> If entire approach is accepted (and correct), there are no dependencies and
> patches can be picked independently. Although the best in the same cycle, so
> there will be no new `dtbs_check` warnings.
>
> Best regards,
> Krzysztof
Looks like this was only partially merged, resulting in schema warnings

Konrad

2023-08-05 20:52:59

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v3 00/11] mailbox/arm64/ qcom: rework compatibles for fallback

On 05/08/2023 14:21, Konrad Dybcio wrote:
> On 22.03.2023 18:41, Krzysztof Kozlowski wrote:
>> Hi,
>>
>> Changes since v2
>> ================
>> 1. Split fixes to separate patchset which is now dependency:
>> https://lore.kernel.org/linux-arm-msm/[email protected]/T/#t
>> 2. Add Ack
>> 3. No other changes, as discussion with Dmitry did not reach conclusion on incompatibility.
>>
>> Changes since v1
>> ================
>> 1. Rebase
>> 2. Make msm8994 fallback for several variants, not msm8953, because the latter
>> actually might take some clocks.
>> 3. Two new patches for SDX55.
>> 4. Minor corrections in bindings style.
>> v1: https://lore.kernel.org/all/[email protected]/
>>
>> Description
>> ===========
>>
>> If entire approach is accepted (and correct), there are no dependencies and
>> patches can be picked independently. Although the best in the same cycle, so
>> there will be no new `dtbs_check` warnings.
>>
>> Best regards,
>> Krzysztof
> Looks like this was only partially merged, resulting in schema warnings

There was discussion/disagreement about the bindings. DTS was applied,
thus it's partially limbo state...

Best regards,
Krzysztof