2023-03-23 07:47:28

by Yang Li

Subject: [PATCH -next] PCI: imx6: Use devm_platform_get_and_ioremap_resource()

According to commit 890cc39a8799 ("drivers: provide
devm_platform_get_and_ioremap_resource()"), convert
platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Yang Li <[email protected]>
---
drivers/pci/controller/dwc/pci-imx6.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
index 55a0405b921d..c61c85e09c4b 100644
--- a/drivers/pci/controller/dwc/pci-imx6.c
+++ b/drivers/pci/controller/dwc/pci-imx6.c
@@ -1259,8 +1259,7 @@ static int imx6_pcie_probe(struct platform_device *pdev)
return PTR_ERR(imx6_pcie->phy_base);
}

- dbi_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- pci->dbi_base = devm_ioremap_resource(dev, dbi_base);
+ pci->dbi_base = devm_platform_get_and_ioremap_resource(pdev, 0, &dbi_base);
if (IS_ERR(pci->dbi_base))
return PTR_ERR(pci->dbi_base);

--
2.20.1.7.g153144c

2023-03-23 08:29:32

by Richard Zhu

Subject: RE: [PATCH -next] PCI: imx6: Use devm_platform_get_and_ioremap_resource()

> -----Original Message-----
> From: Yang Li <[email protected]>
> Sent: 2023??3??23?? 15:46
> To: Hongxing Zhu <[email protected]>
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; Yang Li <[email protected]>
> Subject: [PATCH -next] PCI: imx6: Use
> devm_platform_get_and_ioremap_resource()
>
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert platform_get_resource(),
> devm_ioremap_resource() to a single call to
> devm_platform_get_and_ioremap_resource(), as this is exactly what this function
> does.
>
> Signed-off-by: Yang Li <[email protected]>
Thanks.
Reviewed-by: Richard Zhu <[email protected]>

Best Regards
Richard Zhu

> ---
> drivers/pci/controller/dwc/pci-imx6.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/pci-imx6.c
> b/drivers/pci/controller/dwc/pci-imx6.c
> index 55a0405b921d..c61c85e09c4b 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> @@ -1259,8 +1259,7 @@ static int imx6_pcie_probe(struct platform_device
> *pdev)
> return PTR_ERR(imx6_pcie->phy_base);
> }
>
> - dbi_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - pci->dbi_base = devm_ioremap_resource(dev, dbi_base);
> + pci->dbi_base = devm_platform_get_and_ioremap_resource(pdev, 0,
> +&dbi_base);
> if (IS_ERR(pci->dbi_base))
> return PTR_ERR(pci->dbi_base);
>
> --
> 2.20.1.7.g153144c