2023-03-23 12:33:44

by Dhruva Gole

Subject: [RFC PATCH 2/2] gpio: davinci: Add irq chip flag to skip set wake

Add the IRQCHIP_SKIP_SET_WAKE flag since there are no special IRQ Wake
bits that can be set to enable wakeup IRQ.

Fixes: 3d9edf09d452 ("[ARM] 4457/2: davinci: GPIO support")
Signed-off-by: Dhruva Gole <[email protected]>
---
drivers/gpio/gpio-davinci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index d7595b39e8c4..aaaf61dc2632 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -322,7 +322,7 @@ static struct irq_chip gpio_irqchip = {
.irq_enable = gpio_irq_enable,
.irq_disable = gpio_irq_disable,
.irq_set_type = gpio_irq_type,
- .flags = IRQCHIP_SET_TYPE_MASKED,
+ .flags = IRQCHIP_SET_TYPE_MASKED | IRQCHIP_SKIP_SET_WAKE,
};

static void gpio_irq_handler(struct irq_desc *desc)
--
2.25.1

2023-03-28 13:32:15

by Linus Walleij

Subject: Re: [RFC PATCH 2/2] gpio: davinci: Add irq chip flag to skip set wake

On Thu, Mar 23, 2023 at 1:29 PM Dhruva Gole <[email protected]> wrote:

> Add the IRQCHIP_SKIP_SET_WAKE flag since there are no special IRQ Wake
> bits that can be set to enable wakeup IRQ.
>
> Fixes: 3d9edf09d452 ("[ARM] 4457/2: davinci: GPIO support")
> Signed-off-by: Dhruva Gole <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij