2023-03-23 20:44:14

by Tom Rix

Subject: [PATCH] ALSA: hdspm: remove unused copy_u32_le function

clang with W=1 reports
sound/pci/rme9652/hdspm.c:6149:19: error: unused function
'copy_u32_le' [-Werror,-Wunused-function]
static inline int copy_u32_le(void __user *dest, void __iomem *src)
^
This function is not used so remove it.

Signed-off-by: Tom Rix <[email protected]>
---
sound/pci/rme9652/hdspm.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/sound/pci/rme9652/hdspm.c b/sound/pci/rme9652/hdspm.c
index fa1812e7a49d..267c7848974a 100644
--- a/sound/pci/rme9652/hdspm.c
+++ b/sound/pci/rme9652/hdspm.c
@@ -6146,12 +6146,6 @@ static int snd_hdspm_hwdep_dummy_op(struct snd_hwdep *hw, struct file *file)
return 0;
}

-static inline int copy_u32_le(void __user *dest, void __iomem *src)
-{
- u32 val = readl(src);
- return copy_to_user(dest, &val, 4);
-}
-
static int snd_hdspm_hwdep_ioctl(struct snd_hwdep *hw, struct file *file,
unsigned int cmd, unsigned long arg)
{
--
2.27.0

2023-03-24 07:02:00

by Takashi Iwai

Subject: Re: [PATCH] ALSA: hdspm: remove unused copy_u32_le function

On Thu, 23 Mar 2023 21:27:13 +0100,
Tom Rix wrote:
>
> clang with W=1 reports
> sound/pci/rme9652/hdspm.c:6149:19: error: unused function
> 'copy_u32_le' [-Werror,-Wunused-function]
> static inline int copy_u32_le(void __user *dest, void __iomem *src)
> ^
> This function is not used so remove it.
>
> Signed-off-by: Tom Rix <[email protected]>

Applied to for-next branch. Thanks.


Takashi