2023-03-24 02:18:46

by ye.xingchen

Subject: [PATCH] soc: mediatek: mutex: Use dev_err_probe()

From: Ye Xingchen <[email protected]>

Replace the open-code with dev_err_probe() to simplify the code.

Signed-off-by: Ye Xingchen <[email protected]>
---
drivers/soc/mediatek/mtk-mutex.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediatek/mtk-mutex.c
index 7751527fc30d..05c8ad3c2664 100644
--- a/drivers/soc/mediatek/mtk-mutex.c
+++ b/drivers/soc/mediatek/mtk-mutex.c
@@ -1014,11 +1014,8 @@ static int mtk_mutex_probe(struct platform_device *pdev)

if (!mtx->data->no_clk) {
mtx->clk = devm_clk_get(dev, NULL);
- if (IS_ERR(mtx->clk)) {
- if (PTR_ERR(mtx->clk) != -EPROBE_DEFER)
- dev_err(dev, "Failed to get clock\n");
- return PTR_ERR(mtx->clk);
- }
+ if (IS_ERR(mtx->clk))
+ return dev_err_probe(dev, PTR_ERR(mtx->clk), "Failed to get clock\n");
}

mtx->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &regs);
--
2.25.1

2023-03-24 08:44:19

by AngeloGioacchino Del Regno

Subject: Re: [PATCH] soc: mediatek: mutex: Use dev_err_probe()

Il 24/03/23 03:17, [email protected] ha scritto:
> From: Ye Xingchen <[email protected]>
>
> Replace the open-code with dev_err_probe() to simplify the code.
>
> Signed-off-by: Ye Xingchen <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>

2023-04-02 17:35:26

by Matthias Brugger

Subject: Re: [PATCH] soc: mediatek: mutex: Use dev_err_probe()

On 24/03/2023 03:17, [email protected] wrote:
> From: Ye Xingchen <[email protected]>
>
> Replace the open-code with dev_err_probe() to simplify the code.
>
> Signed-off-by: Ye Xingchen <[email protected]>

Applied, thanks

> ---
> drivers/soc/mediatek/mtk-mutex.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediatek/mtk-mutex.c
> index 7751527fc30d..05c8ad3c2664 100644
> --- a/drivers/soc/mediatek/mtk-mutex.c
> +++ b/drivers/soc/mediatek/mtk-mutex.c
> @@ -1014,11 +1014,8 @@ static int mtk_mutex_probe(struct platform_device *pdev)
>
> if (!mtx->data->no_clk) {
> mtx->clk = devm_clk_get(dev, NULL);
> - if (IS_ERR(mtx->clk)) {
> - if (PTR_ERR(mtx->clk) != -EPROBE_DEFER)
> - dev_err(dev, "Failed to get clock\n");
> - return PTR_ERR(mtx->clk);
> - }
> + if (IS_ERR(mtx->clk))
> + return dev_err_probe(dev, PTR_ERR(mtx->clk), "Failed to get clock\n");
> }
>
> mtx->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &regs);