2023-03-24 02:21:37

by ye.xingchen

Subject: [PATCH] thermal: amlogic: Use dev_err_probe()

From: Ye Xingchen <[email protected]>

Replace the open-code with dev_err_probe() to simplify the code.

Signed-off-by: Ye Xingchen <[email protected]>
---
drivers/thermal/amlogic_thermal.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c
index 4bf36386462f..3abc2dcef408 100644
--- a/drivers/thermal/amlogic_thermal.c
+++ b/drivers/thermal/amlogic_thermal.c
@@ -262,11 +262,8 @@ static int amlogic_thermal_probe(struct platform_device *pdev)
return PTR_ERR(pdata->regmap);

pdata->clk = devm_clk_get(dev, NULL);
- if (IS_ERR(pdata->clk)) {
- if (PTR_ERR(pdata->clk) != -EPROBE_DEFER)
- dev_err(dev, "failed to get clock\n");
- return PTR_ERR(pdata->clk);
- }
+ if (IS_ERR(pdata->clk))
+ return dev_err_probe(dev, PTR_ERR(pdata->clk), "failed to get clock\n");

pdata->sec_ao_map = syscon_regmap_lookup_by_phandle
(pdev->dev.of_node, "amlogic,ao-secure");
--
2.25.1

2023-03-24 10:15:14

by Neil Armstrong

Subject: Re: [PATCH] thermal: amlogic: Use dev_err_probe()

On 24/03/2023 03:20, [email protected] wrote:
> From: Ye Xingchen <[email protected]>
>
> Replace the open-code with dev_err_probe() to simplify the code.
>
> Signed-off-by: Ye Xingchen <[email protected]>
> ---
> drivers/thermal/amlogic_thermal.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c
> index 4bf36386462f..3abc2dcef408 100644
> --- a/drivers/thermal/amlogic_thermal.c
> +++ b/drivers/thermal/amlogic_thermal.c
> @@ -262,11 +262,8 @@ static int amlogic_thermal_probe(struct platform_device *pdev)
> return PTR_ERR(pdata->regmap);
>
> pdata->clk = devm_clk_get(dev, NULL);
> - if (IS_ERR(pdata->clk)) {
> - if (PTR_ERR(pdata->clk) != -EPROBE_DEFER)
> - dev_err(dev, "failed to get clock\n");
> - return PTR_ERR(pdata->clk);
> - }
> + if (IS_ERR(pdata->clk))
> + return dev_err_probe(dev, PTR_ERR(pdata->clk), "failed to get clock\n");
>
> pdata->sec_ao_map = syscon_regmap_lookup_by_phandle
> (pdev->dev.of_node, "amlogic,ao-secure");

Reviewed-by: Neil Armstrong <[email protected]>

2023-03-25 13:24:54

by Martin Blumenstingl

Subject: Re: [PATCH] thermal: amlogic: Use dev_err_probe()

On Fri, Mar 24, 2023 at 3:20 AM <[email protected]> wrote:
>
> From: Ye Xingchen <[email protected]>
>
> Replace the open-code with dev_err_probe() to simplify the code.
>
> Signed-off-by: Ye Xingchen <[email protected]>
Reviewed-by: Martin Blumenstingl <[email protected]>

2023-04-01 20:42:53

by Daniel Lezcano

Subject: Re: [PATCH] thermal: amlogic: Use dev_err_probe()

On 24/03/2023 03:20, [email protected] wrote:
> From: Ye Xingchen <[email protected]>
>
> Replace the open-code with dev_err_probe() to simplify the code.
>
> Signed-off-by: Ye Xingchen <[email protected]>
> ---

Applied, thanks

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog