2023-03-24 13:33:40

by Tom Rix

Subject: [PATCH] phy: rockchip: remove unused hw_to_inno function

clang with W=1 reports
drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c:284:36: error:
unused function 'hw_to_inno' [-Werror,-Wunused-function]
static inline struct inno_dsidphy *hw_to_inno(struct clk_hw *hw)
^
This function is not used so remove it.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
index 726928ff1273..401b0aabb159 100644
--- a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
+++ b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
@@ -281,11 +281,6 @@ struct inno_mipi_dphy_timing inno_mipi_dphy_timing_table_max_2_5ghz[] = {
{2500000000, 0x15, 0x54, 0x7f, 0x15, 0x6a},
};

-static inline struct inno_dsidphy *hw_to_inno(struct clk_hw *hw)
-{
- return container_of(hw, struct inno_dsidphy, pll.hw);
-}
-
static void phy_update_bits(struct inno_dsidphy *inno,
u8 first, u8 second, u8 mask, u8 val)
{
--
2.27.0

2023-04-07 17:46:49

by Nick Desaulniers

Subject: Re: [PATCH] phy: rockchip: remove unused hw_to_inno function

On Fri, Mar 24, 2023 at 6:27 AM Tom Rix <[email protected]> wrote:
>
> clang with W=1 reports
> drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c:284:36: error:
> unused function 'hw_to_inno' [-Werror,-Wunused-function]
> static inline struct inno_dsidphy *hw_to_inno(struct clk_hw *hw)
> ^
> This function is not used so remove it.
>
> Signed-off-by: Tom Rix <[email protected]>

Thanks for the patch!
Reviewed-by: Nick Desaulniers <[email protected]>

> ---
> drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
> index 726928ff1273..401b0aabb159 100644
> --- a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
> +++ b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
> @@ -281,11 +281,6 @@ struct inno_mipi_dphy_timing inno_mipi_dphy_timing_table_max_2_5ghz[] = {
> {2500000000, 0x15, 0x54, 0x7f, 0x15, 0x6a},
> };
>
> -static inline struct inno_dsidphy *hw_to_inno(struct clk_hw *hw)
> -{
> - return container_of(hw, struct inno_dsidphy, pll.hw);
> -}
> -
> static void phy_update_bits(struct inno_dsidphy *inno,
> u8 first, u8 second, u8 mask, u8 val)
> {
> --
> 2.27.0
>


--
Thanks,
~Nick Desaulniers

2023-04-12 16:22:25

by Vinod Koul

Subject: Re: [PATCH] phy: rockchip: remove unused hw_to_inno function

On 24-03-23, 09:26, Tom Rix wrote:
> clang with W=1 reports
> drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c:284:36: error:
> unused function 'hw_to_inno' [-Werror,-Wunused-function]
> static inline struct inno_dsidphy *hw_to_inno(struct clk_hw *hw)

Applied, thanks

--
~Vinod