2023-03-24 06:09:36

by Li zeming

Subject: [PATCH] base: power: main: remove unnecessary (void*) conversions

Pointer variables of void * type do not require type cast.

Signed-off-by: Li zeming <[email protected]>
---
drivers/base/power/main.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
index c50139207794..f85f3515c258 100644
--- a/drivers/base/power/main.c
+++ b/drivers/base/power/main.c
@@ -679,7 +679,7 @@ static bool dpm_async_fn(struct device *dev, async_func_t func)

static void async_resume_noirq(void *data, async_cookie_t cookie)
{
- struct device *dev = (struct device *)data;
+ struct device *dev = data;
int error;

error = device_resume_noirq(dev, pm_transition, true);
@@ -816,7 +816,7 @@ static int device_resume_early(struct device *dev, pm_message_t state, bool asyn

static void async_resume_early(void *data, async_cookie_t cookie)
{
- struct device *dev = (struct device *)data;
+ struct device *dev = data;
int error;

error = device_resume_early(dev, pm_transition, true);
@@ -980,7 +980,7 @@ static int device_resume(struct device *dev, pm_message_t state, bool async)

static void async_resume(void *data, async_cookie_t cookie)
{
- struct device *dev = (struct device *)data;
+ struct device *dev = data;
int error;

error = device_resume(dev, pm_transition, true);
@@ -1269,7 +1269,7 @@ static int __device_suspend_noirq(struct device *dev, pm_message_t state, bool a

static void async_suspend_noirq(void *data, async_cookie_t cookie)
{
- struct device *dev = (struct device *)data;
+ struct device *dev = data;
int error;

error = __device_suspend_noirq(dev, pm_transition, true);
@@ -1450,7 +1450,7 @@ static int __device_suspend_late(struct device *dev, pm_message_t state, bool as

static void async_suspend_late(void *data, async_cookie_t cookie)
{
- struct device *dev = (struct device *)data;
+ struct device *dev = data;
int error;

error = __device_suspend_late(dev, pm_transition, true);
@@ -1727,7 +1727,7 @@ static int __device_suspend(struct device *dev, pm_message_t state, bool async)

static void async_suspend(void *data, async_cookie_t cookie)
{
- struct device *dev = (struct device *)data;
+ struct device *dev = data;
int error;

error = __device_suspend(dev, pm_transition, true);
--
2.18.2

2023-04-07 11:30:29

by Rafael J. Wysocki

Subject: Re: [PATCH] base: power: main: remove unnecessary (void*) conversions

On Fri, Mar 24, 2023 at 6:48 AM Li zeming <[email protected]> wrote:
>
> Pointer variables of void * type do not require type cast.
>
> Signed-off-by: Li zeming <[email protected]>
> ---
> drivers/base/power/main.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
> index c50139207794..f85f3515c258 100644
> --- a/drivers/base/power/main.c
> +++ b/drivers/base/power/main.c
> @@ -679,7 +679,7 @@ static bool dpm_async_fn(struct device *dev, async_func_t func)
>
> static void async_resume_noirq(void *data, async_cookie_t cookie)
> {
> - struct device *dev = (struct device *)data;
> + struct device *dev = data;
> int error;
>
> error = device_resume_noirq(dev, pm_transition, true);
> @@ -816,7 +816,7 @@ static int device_resume_early(struct device *dev, pm_message_t state, bool asyn
>
> static void async_resume_early(void *data, async_cookie_t cookie)
> {
> - struct device *dev = (struct device *)data;
> + struct device *dev = data;
> int error;
>
> error = device_resume_early(dev, pm_transition, true);
> @@ -980,7 +980,7 @@ static int device_resume(struct device *dev, pm_message_t state, bool async)
>
> static void async_resume(void *data, async_cookie_t cookie)
> {
> - struct device *dev = (struct device *)data;
> + struct device *dev = data;
> int error;
>
> error = device_resume(dev, pm_transition, true);
> @@ -1269,7 +1269,7 @@ static int __device_suspend_noirq(struct device *dev, pm_message_t state, bool a
>
> static void async_suspend_noirq(void *data, async_cookie_t cookie)
> {
> - struct device *dev = (struct device *)data;
> + struct device *dev = data;
> int error;
>
> error = __device_suspend_noirq(dev, pm_transition, true);
> @@ -1450,7 +1450,7 @@ static int __device_suspend_late(struct device *dev, pm_message_t state, bool as
>
> static void async_suspend_late(void *data, async_cookie_t cookie)
> {
> - struct device *dev = (struct device *)data;
> + struct device *dev = data;
> int error;
>
> error = __device_suspend_late(dev, pm_transition, true);
> @@ -1727,7 +1727,7 @@ static int __device_suspend(struct device *dev, pm_message_t state, bool async)
>
> static void async_suspend(void *data, async_cookie_t cookie)
> {
> - struct device *dev = (struct device *)data;
> + struct device *dev = data;
> int error;
>
> error = __device_suspend(dev, pm_transition, true);
> --

Applied as 6.4 material with some edits in the subject and changelog, thanks!