2023-03-26 00:40:23

by Tom Rix

Subject: [PATCH] qed: remove unused num_ooo_add_to_peninsula variable

clang with W=1 reports
drivers/net/ethernet/qlogic/qed/qed_ll2.c:649:6: error: variable
'num_ooo_add_to_peninsula' set but not used [-Werror,-Wunused-but-set-variable]
u32 num_ooo_add_to_peninsula = 0, cid;
^
This variable is not used so remove it.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/net/ethernet/qlogic/qed/qed_ll2.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
index e5116a86cfbc..717a0b3f89bd 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_ll2.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
@@ -646,13 +646,13 @@ static int qed_ll2_lb_rxq_handler(struct qed_hwfn *p_hwfn,
struct qed_ll2_rx_queue *p_rx = &p_ll2_conn->rx_queue;
u16 packet_length = 0, parse_flags = 0, vlan = 0;
struct qed_ll2_rx_packet *p_pkt = NULL;
- u32 num_ooo_add_to_peninsula = 0, cid;
union core_rx_cqe_union *cqe = NULL;
u16 cq_new_idx = 0, cq_old_idx = 0;
struct qed_ooo_buffer *p_buffer;
struct ooo_opaque *ooo_opq;
u8 placement_offset = 0;
u8 cqe_type;
+ u32 cid;

cq_new_idx = le16_to_cpu(*p_rx->p_fw_cons);
cq_old_idx = qed_chain_get_cons_idx(&p_rx->rcq_chain);
@@ -762,7 +762,6 @@ static int qed_ll2_lb_rxq_handler(struct qed_hwfn *p_hwfn,
cid, ooo_opq->ooo_isle);
break;
case TCP_EVENT_ADD_PEN:
- num_ooo_add_to_peninsula++;
qed_ooo_put_ready_buffer(p_hwfn,
p_hwfn->p_ooo_info,
p_buffer, true);
--
2.27.0

2023-03-26 08:12:03

by Simon Horman

Subject: Re: [PATCH] qed: remove unused num_ooo_add_to_peninsula variable

On Sat, Mar 25, 2023 at 08:17:33PM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/net/ethernet/qlogic/qed/qed_ll2.c:649:6: error: variable
> 'num_ooo_add_to_peninsula' set but not used [-Werror,-Wunused-but-set-variable]
> u32 num_ooo_add_to_peninsula = 0, cid;
> ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <[email protected]>

Reviewed-by: Simon Horman <[email protected]>

2023-03-28 02:51:57

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] qed: remove unused num_ooo_add_to_peninsula variable

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:

On Sat, 25 Mar 2023 20:17:33 -0400 you wrote:
> clang with W=1 reports
> drivers/net/ethernet/qlogic/qed/qed_ll2.c:649:6: error: variable
> 'num_ooo_add_to_peninsula' set but not used [-Werror,-Wunused-but-set-variable]
> u32 num_ooo_add_to_peninsula = 0, cid;
> ^
> This variable is not used so remove it.
>
> [...]

Here is the summary with links:
- qed: remove unused num_ooo_add_to_peninsula variable
https://git.kernel.org/netdev/net-next/c/2bcc74ffd21a

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html