2023-03-24 16:32:59

by Thomas Weißschuh

Subject: [PATCH RESEND] firmware: turris-mox-rwtm: make kobj_type structure constant

Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
the driver core allows the usage of const struct kobj_type.

Take advantage of this to constify the structure definition to prevent
modification at runtime.

Signed-off-by: Thomas Weißschuh <[email protected]>
---
drivers/firmware/turris-mox-rwtm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/turris-mox-rwtm.c b/drivers/firmware/turris-mox-rwtm.c
index 6ea5789a89e2..2de0fb139ce1 100644
--- a/drivers/firmware/turris-mox-rwtm.c
+++ b/drivers/firmware/turris-mox-rwtm.c
@@ -104,7 +104,7 @@ static void mox_kobj_release(struct kobject *kobj)
kfree(to_rwtm(kobj)->kobj);
}

-static struct kobj_type mox_kobj_ktype = {
+static const struct kobj_type mox_kobj_ktype = {
.release = mox_kobj_release,
.sysfs_ops = &kobj_sysfs_ops,
};

---
base-commit: 2fcd07b7ccd5fd10b2120d298363e4e6c53ccf9c
change-id: 20230227-kobj_type-firmware-turris-6cd4a66bac19

Best regards,
--
Thomas Weißschuh <[email protected]>

2023-03-26 12:58:42

by Marek Behún

Subject: Re: [PATCH RESEND] firmware: turris-mox-rwtm: make kobj_type structure constant

Didn't I already give reviewed-by tag?

Reviewed-by: Marek Beh?n <[email protected]>

On Fri, Mar 24, 2023 at 04:27:50PM +0000, Thomas Wei?schuh wrote:
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
>
> Take advantage of this to constify the structure definition to prevent
> modification at runtime.
>
> Signed-off-by: Thomas Wei?schuh <[email protected]>
> ---
> drivers/firmware/turris-mox-rwtm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/turris-mox-rwtm.c b/drivers/firmware/turris-mox-rwtm.c
> index 6ea5789a89e2..2de0fb139ce1 100644
> --- a/drivers/firmware/turris-mox-rwtm.c
> +++ b/drivers/firmware/turris-mox-rwtm.c
> @@ -104,7 +104,7 @@ static void mox_kobj_release(struct kobject *kobj)
> kfree(to_rwtm(kobj)->kobj);
> }
>
> -static struct kobj_type mox_kobj_ktype = {
> +static const struct kobj_type mox_kobj_ktype = {
> .release = mox_kobj_release,
> .sysfs_ops = &kobj_sysfs_ops,
> };
>
> ---
> base-commit: 2fcd07b7ccd5fd10b2120d298363e4e6c53ccf9c
> change-id: 20230227-kobj_type-firmware-turris-6cd4a66bac19
>
> Best regards,
> --
> Thomas Wei?schuh <[email protected]>
>

2023-03-27 00:22:48

by Thomas Weißschuh

Subject: Re: [PATCH RESEND] firmware: turris-mox-rwtm: make kobj_type structure constant

Hi Marek,

On 2023-03-26 14:58:16+0200, Marek Behún wrote:
> Didn't I already give reviewed-by tag?

Yes indeed. Sorry for that oversight.

> Reviewed-by: Marek Behún <[email protected]>
>
> On Fri, Mar 24, 2023 at 04:27:50PM +0000, Thomas Weißschuh wrote:
> > Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> > the driver core allows the usage of const struct kobj_type.
> >
> > Take advantage of this to constify the structure definition to prevent
> > modification at runtime.
> >
> > Signed-off-by: Thomas Weißschuh <[email protected]>
> > ---
> > drivers/firmware/turris-mox-rwtm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)

2023-04-07 15:26:55

by Gregory CLEMENT

Subject: Re: [PATCH RESEND] firmware: turris-mox-rwtm: make kobj_type structure constant

Thomas Weißschuh <[email protected]> writes:

> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
>
> Take advantage of this to constify the structure definition to prevent
> modification at runtime.
>

Applied on mvebu/arm64

Thanks,

Gregory
> Signed-off-by: Thomas Weißschuh <[email protected]>
> ---
> drivers/firmware/turris-mox-rwtm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/turris-mox-rwtm.c b/drivers/firmware/turris-mox-rwtm.c
> index 6ea5789a89e2..2de0fb139ce1 100644
> --- a/drivers/firmware/turris-mox-rwtm.c
> +++ b/drivers/firmware/turris-mox-rwtm.c
> @@ -104,7 +104,7 @@ static void mox_kobj_release(struct kobject *kobj)
> kfree(to_rwtm(kobj)->kobj);
> }
>
> -static struct kobj_type mox_kobj_ktype = {
> +static const struct kobj_type mox_kobj_ktype = {
> .release = mox_kobj_release,
> .sysfs_ops = &kobj_sysfs_ops,
> };
>
> ---
> base-commit: 2fcd07b7ccd5fd10b2120d298363e4e6c53ccf9c
> change-id: 20230227-kobj_type-firmware-turris-6cd4a66bac19
>
> Best regards,
> --
> Thomas Weißschuh <[email protected]>
>

--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com